This is an archive of the discontinued LLVM Phabricator instance.

[OpenMP] Use AAAssumptionInfo to get assumptions in OpenMPOpt
ClosedPublic

Authored by jhuber6 on Oct 8 2021, 10:46 AM.

Details

Summary

This patch uses the abstract attributor introduced in D111054 to get the
assumption values instead of the hasAssumption function. This also
calls it so assumption information should propagate throug the device
where applicabile.

Diff Detail

Event Timeline

jhuber6 created this revision.Oct 8 2021, 10:46 AM
jhuber6 requested review of this revision.Oct 8 2021, 10:46 AM
Herald added a reviewer: baziotis. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript

Can we have a test where the attribute is not directly attached but propagated?

llvm/lib/Transforms/IPO/OpenMPOpt.cpp
4447

Do we need these? The getAAFor code should create all AAs we need on demand, no?

jhuber6 updated this revision to Diff 385950.Nov 9 2021, 1:07 PM

Add test and don't seed the AAAssumptionInfo.

This revision is now accepted and ready to land.Nov 9 2021, 1:15 PM
This revision was landed with ongoing or failed builds.Nov 9 2021, 2:39 PM
This revision was automatically updated to reflect the committed changes.