This is an archive of the discontinued LLVM Phabricator instance.

[VPlan] Print live-in backedge taken count as part of plan.
ClosedPublic

Authored by fhahn on Oct 7 2021, 4:18 AM.

Details

Summary

At the moment, a VPValue is created for the backedge-taken count, which
is used by some recipes. To make it easier to identify the operands of
recipes using the backedge-taken count, print it at the beginning of the
VPlan if it is used.

Diff Detail

Event Timeline

fhahn created this revision.Oct 7 2021, 4:18 AM
fhahn requested review of this revision.Oct 7 2021, 4:18 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 7 2021, 4:18 AM
Herald added a subscriber: vkmr. · View Herald Transcript

LGTM other than a minor nit.

llvm/lib/Transforms/Vectorize/VPlan.cpp
891

This looks strange. Why extra space? What's more interesting is that I don't see it in the CHECKs below.

fhahn updated this revision to Diff 378614.Oct 11 2021, 3:39 AM

remove extra space, thanks!

fhahn marked an inline comment as done.Oct 11 2021, 3:40 AM
fhahn added inline comments.
llvm/lib/Transforms/Vectorize/VPlan.cpp
891

Thanks, I missed the extra space. Removed!

a.elovikov accepted this revision.Oct 11 2021, 9:18 AM

Thanks!

This revision is now accepted and ready to land.Oct 11 2021, 9:18 AM
This revision was automatically updated to reflect the committed changes.
fhahn marked an inline comment as done.