Page MenuHomePhabricator

[clang][Driver] Make multiarch output file basenames reproducible
AcceptedPublic

Authored by keith on Wed, Oct 6, 1:44 PM.

Details

Reviewers
JDevlieghere
Summary

When building a multiarch MachO binary, previously the intermediate
output file names would contain random characters. On macOS this
filename, since it's used when linking, ended up being used as a
stable-ish identifier for the adhoc codesignature of the binary, leading
to non-reproducible binaries. This change uses the architecture, when
available, to create a stable, but unique, basename for the file.

Diff Detail

Event Timeline

keith created this revision.Wed, Oct 6, 1:44 PM
keith requested review of this revision.Wed, Oct 6, 1:44 PM
Herald added a project: Restricted Project. · View Herald TranscriptWed, Oct 6, 1:44 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
keith updated this revision to Diff 377674.Wed, Oct 6, 1:45 PM

Remove debug comment

This revision is now accepted and ready to land.Thu, Oct 7, 10:55 AM
keith updated this revision to Diff 377983.Thu, Oct 7, 1:01 PM

Fix format

keith updated this revision to Diff 378796.Mon, Oct 11, 2:19 PM

Fix slashes for windows

keith updated this revision to Diff 379570.Wed, Oct 13, 5:46 PM

Fix windows test paths