This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU] Support shared literals in FMAMK/FMAAK
ClosedPublic

Authored by Joe_Nash on Oct 4 2021, 9:03 AM.

Details

Summary

These instructions should allow src0 to be a literal with the same
value as the mandatory other literal. Enable it by introducing an
operand that defers adding its value to the MI when decoding till
the mandatory literal is parsed.

Diff Detail

Event Timeline

Joe_Nash created this revision.Oct 4 2021, 9:03 AM
Joe_Nash requested review of this revision.Oct 4 2021, 9:03 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 4 2021, 9:03 AM
dp accepted this revision.Oct 6 2021, 6:17 AM

Looks fine to me. Maybe a little hacky, but I do not see any possibilities for improvement.

This revision is now accepted and ready to land.Oct 6 2021, 6:17 AM
foad added a comment.Oct 6 2021, 6:55 AM

Does this affect madmk/madak as well as fmamk/fmaak?

Does this affect madmk/madak as well as fmamk/fmaak?

Yes, good point. I will add some tests for this.

Joe_Nash updated this revision to Diff 377945.Oct 7 2021, 11:58 AM

shared literals are also supported in madak and madmk, the earlier
versions of fmamk, fmaak. Add tests for these. Update the literal
validation to support shared literals.

foad accepted this revision.Oct 11 2021, 1:37 AM

Thanks. I think this still looks good.

This revision was automatically updated to reflect the committed changes.