Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

[lldb] Add support for D programming language
ClosedPublic
Actions

Authored by ljmf00 on Sep 27 2021, 1:03 PM.

Details

Reviewers

JDevlieghere
teemperor

Commits

rG96a735990839: [lldb] Add support for demangling D symbols

Summary

This is part of https://github.com/dlang/projects/issues/81 .

This patch enables support for D programming language demangler by using a
pretty printed stacktrace with demangled D symbols, when present.

Signed-off-by: Luís Ferreira <contact@lsferreira.net>

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

ljmf00 requested review of this revision.Sep 27 2021, 1:03 PM

ljmf00 created this revision.

ljmf00 created this object with edit policy "Administrators".

ljmf00 added a parent revision: D110577: [llvm-cxxfilt] Enable support for D programming language demangling.

ljmf00 set the repository for this revision to rG LLVM Github Monorepo.

ljmf00 added a project: Restricted Project.

Herald added a project: Restricted Project. · View Herald TranscriptSep 27 2021, 1:04 PM

Herald added a subscriber: lldb-commits. · View Herald Transcript

Harbormaster completed remote builds in B125953: Diff 375379.Sep 27 2021, 1:06 PM

Herald added a subscriber: JDevlieghere. · View Herald TranscriptSep 27 2021, 1:06 PM

ljmf00 changed the edit policy from "Administrators" to "All Users".Sep 28 2021, 8:43 AM

LGTM

This revision is now accepted and ready to land.Sep 28 2021, 8:46 AM

Do you have commit access or should someone land this for you?

lldb/include/lldb/Core/Mangled.h
48	Nit which can be fixed when landing (so no need to update this revision): Could we add a trailing comma here just to keep the (future) git blame a bit cleaner once we get patches that add E, F, G, etc. support.

In D110578#3027692, @teemperor wrote:

Do you have commit access or should someone land this for you?

I don't have commit access, although this is a stacked revision, so there are some dependent patches.

In D110578#3027707, @ljmf00 wrote:

In D110578#3027692, @teemperor wrote:

Do you have commit access or should someone land this for you?

I don't have commit access, although this is a stacked revision, so there are some dependent patches.

Alright, feel free to ping then if this is ready to land (or maybe ping the person for the dependent patch to land this too). Thanks!

ljmf00 updated this revision to Diff 378255.Oct 8 2021, 8:49 AM

ljmf00 edited parent revisions, added: D111415: [Demangle] Add support for D simple single qualified names; removed: D110577: [llvm-cxxfilt] Enable support for D programming language demangling.

ljmf00 edited parent revisions, added: D111414: [Demangle] Add minimal support for D programming language; removed: D111415: [Demangle] Add support for D simple single qualified names.

Harbormaster completed remote builds in B127794: Diff 378255.Oct 8 2021, 8:52 AM

ljmf00 added a subscriber: Geod24.Oct 8 2021, 8:59 AM

Since D111414 got merged, @teemperor can you land this?

@dblaikie Maybe you can land this?

In D110578#3123164, @ljmf00 wrote:

@dblaikie Maybe you can land this?

Nah, might need someone with more lldb context than me - I don't seem to have a clean check-lldb build right now (so don't have a good baseline to validate that the patch doesn't regress anything before I commit) & no idea why... :/

Closed by commit rG96a735990839: [lldb] Add support for demangling D symbols (authored by ljmf00, committed by teemperor). · Explain WhyNov 11 2021, 2:12 AM

This revision was automatically updated to reflect the committed changes.

teemperor added a commit: rG96a735990839: [lldb] Add support for demangling D symbols.

I changed the commit name from "Add support for D programming language" to "[lldb] Add support for demangling D symbols" when landing (which is more accurate).