Page MenuHomePhabricator

Geod24 (Mathias LANG)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 15 2020, 1:46 AM (122 w, 6 d)

Recent Activity

Oct 21 2021

Geod24 accepted D111948: [Demangle] Add prepend functionality to OutputString.

LGTM

Oct 21 2021, 7:32 PM · Restricted Project, Restricted Project

Oct 17 2021

Geod24 added inline comments to D111947: [Demangle] Rename OutputStream to OutputString.
Oct 17 2021, 7:25 AM · Restricted Project, Restricted Project

Sep 28 2021

Geod24 added a comment to D110576: [Demangle] Add support for D programming language.

As with the Rust demangling (check the commit history, it was done earlier this year), I think this'd be easier to review if it were implemented incrementally - it'll be easier to spot the test coverage for each feature as it's added. Otherwise it's a lot of code to try to validate in one piece.

Sep 28 2021, 8:15 PM · Restricted Project

May 13 2020

Geod24 added a comment to D79559: [lldb] Also recognize DWARF UTF base types using their size.

Thanks!
I suppose this won't be in the next patch release (10.0.1) but instead in the next major ?

May 13 2020, 4:48 AM · Restricted Project
Geod24 added a comment to D79559: [lldb] Also recognize DWARF UTF base types using their size.

Good to know, thanks! It's also my first time using arc, so I had to poke around a bit. In any case I didn't seem to include that whitespace fix even after squashing the commits together. If this is fine as is, then great.

May 13 2020, 2:39 AM · Restricted Project

May 12 2020

Geod24 updated the diff for D79559: [lldb] Also recognize DWARF UTF base types using their size.

Merge whitespace-removing commit into the main one

May 12 2020, 11:16 AM · Restricted Project
Geod24 updated the diff for D79559: [lldb] Also recognize DWARF UTF base types using their size.

Add missing commit

May 12 2020, 10:11 AM · Restricted Project
Geod24 updated the diff for D79559: [lldb] Also recognize DWARF UTF base types using their size.

Remove a trailing whitespace in TypeSystemClang.cpp

May 12 2020, 10:11 AM · Restricted Project
Geod24 updated the diff for D79559: [lldb] Also recognize DWARF UTF base types using their size.

Remove un-needed main & use x86_64-pc-gnu as target instead of host

May 12 2020, 8:34 AM · Restricted Project
Geod24 updated the diff for D79559: [lldb] Also recognize DWARF UTF base types using their size.

Changed the test from running to 'type lookup string'

May 12 2020, 5:20 AM · Restricted Project

May 7 2020

Geod24 updated the diff for D79559: [lldb] Also recognize DWARF UTF base types using their size.

Added Shell test

May 7 2020, 11:57 PM · Restricted Project
Geod24 created D79559: [lldb] Also recognize DWARF UTF base types using their size.
May 7 2020, 2:48 AM · Restricted Project
Geod24 added a comment to D79559: [lldb] Also recognize DWARF UTF base types using their size.

I wasn't sure what would be the best place / how to add an unit test for this. Could a reviewer provide some pointers ?

May 7 2020, 2:48 AM · Restricted Project