This is an archive of the discontinued LLVM Phabricator instance.

[llvm-dwarfdump][docs] Add missing options to the help output and the command guide
ClosedPublic

Authored by gbreynoo on Sep 24 2021, 7:04 AM.

Details

Summary

This change is to add some missing details to the help text and command guide:

  • Added a note to the command guide that ----debug-macro also dumps .debug_macinfo.
  • Added a note to the command guide that --debug-frame and --eh_frame - are aliases, and in cases where both sections are present one command outputs both.
  • Changed the wording in the help output for --ignore-case and --regex to closer match the command guide.

Diff Detail

Event Timeline

gbreynoo created this revision.Sep 24 2021, 7:04 AM
gbreynoo requested review of this revision.Sep 24 2021, 7:04 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 24 2021, 7:04 AM
dblaikie accepted this revision.Sep 24 2021, 11:43 AM

Sounds good to me!

llvm/docs/CommandGuide/llvm-dwarfdump.rst
162

Maybe put these on separate lines to make sure the debug-frame one doesn't get lost behind the debug-macro one?

This revision is now accepted and ready to land.Sep 24 2021, 11:43 AM
djtodoro accepted this revision.Sep 27 2021, 1:53 AM
gbreynoo marked an inline comment as done.Sep 27 2021, 6:31 AM
gbreynoo added inline comments.
llvm/docs/CommandGuide/llvm-dwarfdump.rst
162

Thanks dblaikie, done.

gbreynoo marked an inline comment as done.Sep 27 2021, 6:33 AM
This comment was removed by gbreynoo.
gbreynoo closed this revision.Sep 27 2021, 6:41 AM

This was committed in 05b1c7aebfff8cc08a620d01e739f343ed01db6d but I forgot to add the Differential Revision URL. As stated in the Code Reviews with Phabricator User Guide I will close this revision. Apologies for the noise.