Page MenuHomePhabricator

[X86] Rename the X86WinAllocaExpander pass and related symbols to "DynAlloca". NFC
ClosedPublic

Authored by aemerson on Sep 17 2021, 12:19 PM.

Details

Summary

For x86 Darwin, we have a stack checking feature which re-uses some of this machinery around stack probing on Windows. Renaming this to be more appropriate for a generic feature.

Diff Detail

Event Timeline

aemerson created this revision.Sep 17 2021, 12:19 PM
aemerson requested review of this revision.Sep 17 2021, 12:19 PM

This probably needs a mention in the release notes

Is there any way that we can ensure we have preparatory test coverage for this with a darwin triple or is that premature?

llvm/lib/Target/X86/X86DynAllocaExpander.cpp
198

Fix this?

llvm/utils/gn/secondary/llvm/lib/Target/X86/BUILD.gn
136–137

sorting

aemerson updated this revision to Diff 373435.Sat, Sep 18, 3:09 PM

This probably needs a mention in the release notes

Is there any way that we can ensure we have preparatory test coverage for this with a darwin triple or is that premature?

The feature hasn't yet been upstreamed yet, it's tied quite closely with macOS so has been shipping with Apple clang for a few years now. This is one of the downstream patches we've had. The rest we will upstream in due course and when we do I'll add a release note for it.

RKSimon accepted this revision.Sun, Sep 19, 4:55 AM

LGTM - I'd still prefer this rename is documented in the release notes for future reference - you can adjust the note as you make further additions.

This revision is now accepted and ready to land.Sun, Sep 19, 4:55 AM
This revision was landed with ongoing or failed builds.Mon, Sep 20, 4:19 PM
This revision was automatically updated to reflect the committed changes.