This is an archive of the discontinued LLVM Phabricator instance.

[mlir][OpDSL] Update op definitions to make shapes more concise (NFC).
ClosedPublic

Authored by gysit on Sep 15 2021, 1:40 AM.

Details

Summary

Express the input shape definitions of convolution and pooling operations in terms of the output shapes, filter shapes, strides, and dilations.

Diff Detail

Event Timeline

gysit created this revision.Sep 15 2021, 1:40 AM
gysit requested review of this revision.Sep 15 2021, 1:40 AM
shabalin accepted this revision.EditedSep 15 2021, 1:57 AM

The new signatures look good to me! They resolve the issue with prior definitions being not precise enough in terms of the dimensions of inputs.

This revision is now accepted and ready to land.Sep 15 2021, 1:57 AM
stellaraccident accepted this revision.Sep 15 2021, 7:20 AM
rsuderman accepted this revision.Sep 15 2021, 10:36 AM