Page MenuHomePhabricator

[openmp][docs] Describe how the internal components are found
ClosedPublic

Authored by JonChesterfield on Sep 10 2021, 11:22 AM.

Details

Summary

Add a FAQ entry about the names of openmp offloading components
and how they are searched for.

Diff Detail

Event Timeline

JonChesterfield requested review of this revision.Sep 10 2021, 11:22 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 10 2021, 11:22 AM

LG, quite descriptive and covers everything related to OpenMP libraries. Waiting for others to comment as well.

The literals should go inside of an inline literal block (Two backticks).

I can't make phab print two ` next to each other but sure, happy to. Which strings do you have in mind? You're also very welcome to take over the diff and add quotes wherever looks appropriate, probably faster than writing a comment about it

jhuber6 added inline comments.Sep 30 2021, 1:54 PM
openmp/docs/SupportAndFAQ.rst
167

I'd suggest anything like this that contains underscores or dashes. I'll leave it up to you if you want to put it around the library names as well.

198
  • quote literals
jhuber6 accepted this revision.Sep 30 2021, 2:04 PM

LGTM, thanks.

This revision is now accepted and ready to land.Sep 30 2021, 2:04 PM

Have gone with environment variables, library names, clang arguments and $ORIGIN. Also replaced -rpath with -Wl,-rpath as that's more explicitly a linker thing.