This is an archive of the discontinued LLVM Phabricator instance.

[mips][microMIPS] Add microMIPS32r6 and microMIPS64r6 tests for existing 16-bit ADDIUR1SP, ADDIUR2, ADDIUS5 and ADDIUSP instructions
ClosedPublic

Authored by zbuljan on Jul 6 2015, 4:42 AM.

Details

Summary

The patch adds microMIPS32r6 and microMIPS64r6 tests for existing 16-bit ADDIUR1SP, ADDIUR2, ADDIUS5 and ADDIUSP instructions.

Diff Detail

Event Timeline

zbuljan updated this revision to Diff 29074.Jul 6 2015, 4:42 AM
zbuljan retitled this revision from to [mips][microMIPS] Add microMIPS32r6 and microMIPS64r6 tests for existing 16-bit ADDIUR1SP, ADDIUR2, ADDIUS5 and ADDIUSP instructions.
zbuljan updated this object.
zbuljan added subscribers: petarj, llvm-commits.
zbuljan updated this revision to Diff 29082.Jul 6 2015, 6:30 AM

Added disassembler tests for instructions.

dsanders accepted this revision.Aug 13 2015, 5:57 AM
dsanders edited edge metadata.

LGTM, possibly with a couple nits.

test/MC/Mips/micromips32r6/invalid.s
6–7

Should these (and the one on line 4) be:

error: immediate operand value out of range

If so, they should be in invalid-wrong-error.s. If the current error is the one we want then it's ok here.

test/MC/Mips/micromips64r6/invalid.s
7–8

Likewise.

This revision is now accepted and ready to land.Aug 13 2015, 5:57 AM
This revision was automatically updated to reflect the committed changes.