[mlir][sparse] Mark convert op as noSideEffect

[aartbik]

No test was impacted? (good means, no dead uses ;-)

Bonus points if you add a DCE test now that it is no-side effects, but also good to go like this.....

[ThomasRaoux]

In D109543#2992641, @aartbik wrote:

No test was impacted? (good means, no dead uses ;-)

Bonus points if you add a DCE test now that it is no-side effects, but also good to go like this.....

I was thinking about that. I didn't find an obvious place to add it. I could add a test file for canonicalization as we discussed adding more canonicalization for those ops in the future?

[aartbik]

In D109543#2992705, @ThomasRaoux wrote:

In D109543#2992641, @aartbik wrote:

No test was impacted? (good means, no dead uses ;-)

Bonus points if you add a DCE test now that it is no-side effects, but also good to go like this.....

I was thinking about that. I didn't find an obvious place to add it. I could add a test file for canonicalization as we discussed adding more canonicalization for those ops in the future?

I am also adding a test for the new folder I wrote. So I can include the new test in that same suite. So go ahead with this revision!

[ThomasRaoux]

In D109543#2992711, @aartbik wrote:

In D109543#2992705, @ThomasRaoux wrote:

In D109543#2992641, @aartbik wrote:

No test was impacted? (good means, no dead uses ;-)

Bonus points if you add a DCE test now that it is no-side effects, but also good to go like this.....

I was thinking about that. I didn't find an obvious place to add it. I could add a test file for canonicalization as we discussed adding more canonicalization for those ops in the future?

I am also adding a test for the new folder I wrote. So I can include the new test in that same suite. So go ahead with this revision!

:)

mlir/include/mlir/Dialect/SparseTensor/IR/SparseTensorOps.td

string description = [{
 
     ```mlir
     sparse_tensor.new %source : !Source to tensor<1024x1024xf64, #CSR>
     ```
   }];
   let assemblyFormat = "$source attr-dict `:` type($source) `to` type($result)";
 }
 
-def SparseTensor_ConvertOp : SparseTensor_Op<"convert", [SameOperandsAndResultType]>,
+def SparseTensor_ConvertOp : SparseTensor_Op<"convert",
+  [NoSideEffect, SameOperandsAndResultType]>,
     Arguments<(ins AnyTensor:$source)>,
     Results<(outs AnyTensor:$dest)> {
   string summary = "Converts between different tensor types";
   string description = [{
     Converts one sparse or dense tensor type to another tensor type. The rank
     and dimensions of the source and destination types must match exactly,
     only the sparse encoding of these types may be different. The name `convert`
     was preferred over `cast`, since the operation may incur a non-trivial cost.