This is an archive of the discontinued LLVM Phabricator instance.

[mlir][sparse] add casts to operations to lattice and exp builders
ClosedPublic

Authored by aartbik on Sep 7 2021, 7:56 PM.

Details

Summary

Further enhance the set of operations that can be handled by the sparse compiler

Diff Detail

Event Timeline

aartbik created this revision.Sep 7 2021, 7:56 PM
aartbik requested review of this revision.Sep 7 2021, 7:56 PM
bixia added inline comments.Sep 8 2021, 10:21 AM
mlir/include/mlir/Dialect/SparseTensor/Utils/Merger.h
86–88

Would it be more straightforward to say "or the destination type of a cast operation"?

mlir/lib/Dialect/SparseTensor/Utils/Merger.cpp
669

Per offline conversation, it is cleaner to get vl from the type of v0.

aartbik marked 2 inline comments as done.Sep 8 2021, 10:52 AM
aartbik added inline comments.
mlir/lib/Dialect/SparseTensor/Utils/Merger.cpp
669

Yes, it makes this a bit more "black box" with less input from the outside world. Thanks!

aartbik updated this revision to Diff 371454.Sep 8 2021, 2:49 PM
aartbik marked an inline comment as done.

infer vl from local information only

bixia accepted this revision.Sep 8 2021, 11:27 PM
This revision is now accepted and ready to land.Sep 8 2021, 11:27 PM