This is an archive of the discontinued LLVM Phabricator instance.

[mlir] Fix SplatOp lowering to the LLVM dialect
ClosedPublic

Authored by ftynse on Sep 7 2021, 5:28 AM.

Details

Summary

The lowering has been incorrectly using the operands of the original op instead
of rewritten operands provided to matchAndRewrite call. This may lead to
spurious materializations and generally invalid IR.

Diff Detail

Event Timeline

ftynse created this revision.Sep 7 2021, 5:28 AM
ftynse requested review of this revision.Sep 7 2021, 5:28 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 7 2021, 5:28 AM
aartbik accepted this revision.Sep 7 2021, 10:08 AM
This revision is now accepted and ready to land.Sep 7 2021, 10:08 AM
This revision was automatically updated to reflect the committed changes.