Page MenuHomePhabricator

[AggresiveInstCombine] Add wrapper calls for `KnownBits` computing
ClosedPublic

Authored by anton-afanasyev on Sep 5 2021, 6:44 AM.

Details

Summary

Precommit before AssumptionCache adding: reviews.llvm.org/D109141

Diff Detail

Event Timeline

anton-afanasyev created this revision.Sep 5 2021, 6:44 AM
anton-afanasyev requested review of this revision.Sep 5 2021, 6:44 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 5 2021, 6:44 AM
lebedev.ri accepted this revision.Sep 5 2021, 6:59 AM
lebedev.ri added inline comments.
llvm/lib/Transforms/AggressiveInstCombine/AggressiveInstCombineInternal.h
118

same

This revision is now accepted and ready to land.Sep 5 2021, 6:59 AM
lebedev.ri added inline comments.Sep 5 2021, 7:00 AM
llvm/lib/Transforms/AggressiveInstCombine/AggressiveInstCombineInternal.h
111

Ugh. And phab ate my comment yet again.
Let's not add CtxI here, but in a patch that requires it.

anton-afanasyev marked an inline comment as done.Sep 5 2021, 7:58 AM
anton-afanasyev added inline comments.
llvm/lib/Transforms/AggressiveInstCombine/AggressiveInstCombineInternal.h
111

Sure. CtxI isn't used without AC anyway.

anton-afanasyev marked an inline comment as done.

Use /*CtxI=*/nullptr

lebedev.ri accepted this revision.Sep 5 2021, 8:01 AM
This revision was landed with ongoing or failed builds.Sep 7 2021, 6:46 AM
This revision was automatically updated to reflect the committed changes.