This is an archive of the discontinued LLVM Phabricator instance.

Differential D109176

[WebAssemlby] Remove redundant SDTypeProfile. NFC
ClosedPublic

Authored by sbc100 on Sep 2 2021, 11:04 AM.

Details

Reviewers
tlively
Commits
rG4664590d53e0: [WebAssemlby] Remove redundant SDTypeProfile. NFC
Summary

I added this back in https://reviews.llvm.org/D54647 but it wasn't
actually needed.

Diff Detail

Unit TestsFailed

TimeTest
36,460 msx64 debian > libFuzzer.libFuzzer::fork.test

Event Timeline

sbc100 created this revision.Sep 2 2021, 11:04 AM
Herald added subscribers: wingo, hiraditya, jgravelle-google, dschuff. · View Herald TranscriptSep 2 2021, 11:04 AM
sbc100 requested review of this revision.Sep 2 2021, 11:04 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 2 2021, 11:04 AM
Herald added subscribers: llvm-commits, aheejin. · View Herald Transcript
sbc100 added a reviewer: tlively.Sep 2 2021, 11:04 AM
Harbormaster completed remote builds in B122347: Diff 370332.Sep 2 2021, 11:33 AM
sbc100 added a child revision: D109179: [WebAssembly] Rename WrapperPIC -> WrapperREL. NFC.Sep 2 2021, 11:57 AM
tlively accepted this revision.Sep 2 2021, 12:14 PM
This revision is now accepted and ready to land.Sep 2 2021, 12:14 PM
This revision was landed with ongoing or failed builds.Sep 2 2021, 12:21 PM
Closed by commit rG4664590d53e0: [WebAssemlby] Remove redundant SDTypeProfile. NFC (authored by sbc100). · Explain Why
This revision was automatically updated to reflect the committed changes.
sbc100 added a commit: rG4664590d53e0: [WebAssemlby] Remove redundant SDTypeProfile. NFC.

Revision Contents

PathSize
llvm/
lib/
Target/
WebAssembly/
4 lines

Diff 370332

llvm/lib/Target/WebAssembly/WebAssemblyInstrInfo.td

Show First 20 Lines • Show All 71 Lines • ▼ Show 20 Linesdef SDT_WebAssemblyCallSeqEnd :
SDCallSeqEnd<[SDTCisVT<0, iPTR>, SDTCisVT<1, iPTR>]>; SDCallSeqEnd<[SDTCisVT<0, iPTR>, SDTCisVT<1, iPTR>]>;
def SDT_WebAssemblyBrTable : SDTypeProfile<0, -1, [SDTCisPtrTy<0>]>; def SDT_WebAssemblyBrTable : SDTypeProfile<0, -1, [SDTCisPtrTy<0>]>;
def SDT_WebAssemblyArgument : SDTypeProfile<1, 1, [SDTCisVT<1, i32>]>; def SDT_WebAssemblyArgument : SDTypeProfile<1, 1, [SDTCisVT<1, i32>]>;
def SDT_WebAssemblyLocalGet : SDTypeProfile<1, 1, [SDTCisVT<1, i32>]>; def SDT_WebAssemblyLocalGet : SDTypeProfile<1, 1, [SDTCisVT<1, i32>]>;
def SDT_WebAssemblyLocalSet : SDTypeProfile<0, 2, [SDTCisVT<0, i32>]>; def SDT_WebAssemblyLocalSet : SDTypeProfile<0, 2, [SDTCisVT<0, i32>]>;
def SDT_WebAssemblyReturn : SDTypeProfile<0, -1, []>; def SDT_WebAssemblyReturn : SDTypeProfile<0, -1, []>;
def SDT_WebAssemblyWrapper : SDTypeProfile<1, 1, [SDTCisSameAs<0, 1>, def SDT_WebAssemblyWrapper : SDTypeProfile<1, 1, [SDTCisSameAs<0, 1>,
SDTCisPtrTy<0>]>; SDTCisPtrTy<0>]>;
def SDT_WebAssemblyWrapperPIC : SDTypeProfile<1, 1, [SDTCisSameAs<0, 1>,
SDTCisPtrTy<0>]>;
def SDT_WebAssemblyGlobalGet : SDTypeProfile<1, 1, [SDTCisPtrTy<1>]>; def SDT_WebAssemblyGlobalGet : SDTypeProfile<1, 1, [SDTCisPtrTy<1>]>;
def SDT_WebAssemblyGlobalSet : SDTypeProfile<0, 2, [SDTCisPtrTy<1>]>; def SDT_WebAssemblyGlobalSet : SDTypeProfile<0, 2, [SDTCisPtrTy<1>]>;
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// WebAssembly-specific DAG Nodes. // WebAssembly-specific DAG Nodes.
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
def WebAssemblycallseq_start : def WebAssemblycallseq_start :
SDNode<"ISD::CALLSEQ_START", SDT_WebAssemblyCallSeqStart, SDNode<"ISD::CALLSEQ_START", SDT_WebAssemblyCallSeqStart,
[SDNPHasChain, SDNPOutGlue]>; [SDNPHasChain, SDNPOutGlue]>;
def WebAssemblycallseq_end : def WebAssemblycallseq_end :
SDNode<"ISD::CALLSEQ_END", SDT_WebAssemblyCallSeqEnd, SDNode<"ISD::CALLSEQ_END", SDT_WebAssemblyCallSeqEnd,
[SDNPHasChain, SDNPOptInGlue, SDNPOutGlue]>; [SDNPHasChain, SDNPOptInGlue, SDNPOutGlue]>;
def WebAssemblybr_table : SDNode<"WebAssemblyISD::BR_TABLE", def WebAssemblybr_table : SDNode<"WebAssemblyISD::BR_TABLE",
SDT_WebAssemblyBrTable, SDT_WebAssemblyBrTable,
[SDNPHasChain, SDNPVariadic]>; [SDNPHasChain, SDNPVariadic]>;
def WebAssemblyargument : SDNode<"WebAssemblyISD::ARGUMENT", def WebAssemblyargument : SDNode<"WebAssemblyISD::ARGUMENT",
SDT_WebAssemblyArgument>; SDT_WebAssemblyArgument>;
def WebAssemblyreturn : SDNode<"WebAssemblyISD::RETURN", def WebAssemblyreturn : SDNode<"WebAssemblyISD::RETURN",
SDT_WebAssemblyReturn, SDT_WebAssemblyReturn,
[SDNPHasChain, SDNPVariadic]>; [SDNPHasChain, SDNPVariadic]>;
def WebAssemblyWrapper : SDNode<"WebAssemblyISD::Wrapper", def WebAssemblyWrapper : SDNode<"WebAssemblyISD::Wrapper",
SDT_WebAssemblyWrapper>; SDT_WebAssemblyWrapper>;
def WebAssemblyWrapperPIC : SDNode<"WebAssemblyISD::WrapperPIC", def WebAssemblyWrapperPIC : SDNode<"WebAssemblyISD::WrapperPIC",
SDT_WebAssemblyWrapperPIC>; SDT_WebAssemblyWrapper>;
def WebAssemblyglobal_get : def WebAssemblyglobal_get :
SDNode<"WebAssemblyISD::GLOBAL_GET", SDT_WebAssemblyGlobalGet, SDNode<"WebAssemblyISD::GLOBAL_GET", SDT_WebAssemblyGlobalGet,
[SDNPHasChain, SDNPMayLoad, SDNPMemOperand]>; [SDNPHasChain, SDNPMayLoad, SDNPMemOperand]>;
def WebAssemblyglobal_set : def WebAssemblyglobal_set :
SDNode<"WebAssemblyISD::GLOBAL_SET", SDT_WebAssemblyGlobalSet, SDNode<"WebAssemblyISD::GLOBAL_SET", SDT_WebAssemblyGlobalSet,
[SDNPHasChain, SDNPMayStore, SDNPMemOperand]>; [SDNPHasChain, SDNPMayStore, SDNPMemOperand]>;
def WebAssemblylocal_get : def WebAssemblylocal_get :
SDNode<"WebAssemblyISD::LOCAL_GET", SDT_WebAssemblyLocalGet, SDNode<"WebAssemblyISD::LOCAL_GET", SDT_WebAssemblyLocalGet,
▲ Show 20 Lines • Show All 316 Lines • Show Last 20 Lines