[clang][deps] Test diagnostic options are being respected

[jansvoboda11]

Summary

This patch tests code in D108976. This split is necessary to avoid temporary regression.

Depends on D108974,

[dexonsmith]

The test LGTM. I'd prefer you to squash this into https://reviews.llvm.org/D108974 though, since it seems to contain the necessary bits to make the test pass.

[supergrecko]

Hi, are these test cases supposed to be under /llvm in the monorepo? Right now they are at a new path, /llvm/clang/test/... which doesn't look right.

[jansvoboda11]

In D109158#2995095, @supergrecko wrote:

Hi, are these test cases supposed to be under /llvm in the monorepo? Right now they are at a new path, /llvm/clang/test/... which doesn't look right.

You're right, thanks. Fixed in 285ec53730ce6dfecd2a4288388e6ba4f2bd17e4.

llvm/clang/test/ClangScanDeps/Inputs/diagnostics/cdb.json.template

+[
+  {
+    "directory": "DIR",
+    "command": "clang -c DIR/tu.c -fmodules -target i386-apple-ios14.0-simulator -o DIR/tu.o",
+    "file": "DIR/tu.c"
+  }
+]

llvm/clang/test/ClangScanDeps/Inputs/diagnostics/module.modulemap

+module mod { header "mod.h" }

llvm/clang/test/ClangScanDeps/Inputs/diagnostics/tu.c

+#include "mod.h"

llvm/clang/test/ClangScanDeps/diagnostics.c

+// RUN: rm -rf %t && mkdir %t
+// RUN: cp %S/Inputs/diagnostics/* %t
+
+// RUN: sed "s|DIR|%/t|g" %S/Inputs/diagnostics/cdb.json.template > %t/cdb.json
+// RUN: echo -%t > %t/result.json
+// RUN: clang-scan-deps -compilation-database %t/cdb.json -format experimental-full 2>&1 >> %t/result.json
+// RUN: cat %t/result.json | sed 's:\\\\\?:/:g' | FileCheck %s
+
+// Check that the scanner injects '-Wno-error' option and invalid command-line
+// arguments like '-target i386-apple-ios14.0-simulator' do not result in error.
+
+// CHECK-NOT:  error:
+// CHECK:      -[[PREFIX:.*]]
+// CHECK-NEXT: {
+// CHECK-NEXT:   "modules": [
+// CHECK-NEXT:     {
+// CHECK-NEXT:       "clang-module-deps": [],
+// CHECK-NEXT:       "clang-modulemap-file": "[[PREFIX]]/module.modulemap",
+// CHECK-NEXT:       "command-line": [
+// CHECK-NEXT:         "-cc1"
+// CHECK:            ],
+// CHECK-NEXT:       "context-hash": "[[HASH_MOD:.*]]",
+// CHECK-NEXT:       "file-deps": [
+// CHECK-NEXT:         "[[PREFIX]]/mod.h"
+// CHECK-NEXT:         "[[PREFIX]]/module.modulemap"
+// CHECK-NEXT:       ],
+// CHECK-NEXT:       "name": "mod"
+// CHECK-NEXT:     }
+// CHECK-NEXT:   ],
+// CHECK-NEXT:   "translation-units": [
+// CHECK-NEXT:     {
+// CHECK-NEXT:       "clang-context-hash": "[[HASH_TU:.*]],
+// CHECK-NEXT:       "clang-module-deps": [
+// CHECK-NEXT:         {
+// CHECK-NEXT:           "context-hash": "[[HASH_MOD]]",
+// CHECK-NEXT:           "module-name": "mod"
+// CHECK-NEXT:         }
+// CHECK-NEXT:       ],
+// CHECK-NEXT:       "command-line": [
+// CHECK-NEXT:         "-fno-implicit-modules"
+// CHECK-NEXT:         "-fno-implicit-module-maps"
+// CHECK-NEXT:       ],
+// CHECK-NEXT:       "file-deps": [
+// CHECK-NEXT:         "[[PREFIX]]/tu.c"
+// CHECK-NEXT:       ],
+// CHECK-NEXT:       "input-file": "[[PREFIX]]/tu.c"
+// CHECK-NEXT:     }
+// CHECK-NEXT:   ]
+// CHECK-NEXT: }