Page MenuHomePhabricator

[clang][deps] Test diagnostic options are being respected
ClosedPublic

Authored by jansvoboda11 on Sep 2 2021, 7:52 AM.

Details

Summary

This patch tests code in D108976. This split is necessary to avoid temporary regression.

Depends on D108974,

Diff Detail

Event Timeline

jansvoboda11 requested review of this revision.Sep 2 2021, 7:52 AM
jansvoboda11 created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptSep 2 2021, 7:52 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
dexonsmith accepted this revision.Sep 2 2021, 12:24 PM

The test LGTM. I'd prefer you to squash this into https://reviews.llvm.org/D108974 though, since it seems to contain the necessary bits to make the test pass.

This revision is now accepted and ready to land.Sep 2 2021, 12:25 PM
This revision was landed with ongoing or failed builds.Sep 10 2021, 5:48 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptSep 10 2021, 5:48 AM

Hi, are these test cases supposed to be under /llvm in the monorepo? Right now they are at a new path, /llvm/clang/test/... which doesn't look right.

Hi, are these test cases supposed to be under /llvm in the monorepo? Right now they are at a new path, /llvm/clang/test/... which doesn't look right.

You're right, thanks. Fixed in 285ec53730ce6dfecd2a4288388e6ba4f2bd17e4.