This is an archive of the discontinued LLVM Phabricator instance.

Differential D109132

Fix missing argument introduced by D108788
ClosedPublic

Authored by zsrkmyn on Sep 1 2021, 10:51 PM.

Download Raw Diff

Details

Reviewers

aeubanks
rnk
MaskRay

Commits

rGbc0d16969adf: Fix missing argument introduced by D108788

Diff Detail

Event Timeline

zsrkmyn created this revision.Sep 1 2021, 10:51 PM

Herald added subscribers: dexonsmith, jdoerfert. · View Herald TranscriptSep 1 2021, 10:51 PM

zsrkmyn requested review of this revision.Sep 1 2021, 10:51 PM

Herald added a project: Restricted Project. · View Herald TranscriptSep 1 2021, 10:51 PM

Herald added a subscriber: llvm-commits. · View Herald Transcript

Harbormaster completed remote builds in B122244: Diff 370166.Sep 1 2021, 10:51 PM

zsrkmyn mentioned this in D108788: [NFC] Rename attribute methods that work with indexes.Sep 1 2021, 10:52 PM

sorry about that, lgtm

This revision is now accepted and ready to land.Sep 1 2021, 10:56 PM

Could you help land the patch? I don't have write access. Many thanks!

This revision was landed with ongoing or failed builds.Sep 1 2021, 11:02 PM

Closed by commit rGbc0d16969adf: Fix missing argument introduced by D108788 (authored by aeubanks). · Explain Why

This revision was automatically updated to reflect the committed changes.

aeubanks added a commit: rGbc0d16969adf: Fix missing argument introduced by D108788.

done

looks like you have a few patches landed, might want to consider getting push access

Revision Contents

Path

Size

llvm/

include/

llvm/

IR/

2 lines

Diff 370166

llvm/include/llvm/IR/Attributes.h

	Show First 20 Lines • Show All 466 Lines • ▼ Show 20 Lines		public:
	/// Add an attribute to the attribute set at the given index.			/// Add an attribute to the attribute set at the given index.
	/// Returns a new list because attribute lists are immutable.			/// Returns a new list because attribute lists are immutable.
	LLVM_NODISCARD AttributeList			LLVM_NODISCARD AttributeList
	addAttributeAtIndex(LLVMContext &C, unsigned Index, StringRef Kind,			addAttributeAtIndex(LLVMContext &C, unsigned Index, StringRef Kind,
	StringRef Value = StringRef()) const;			StringRef Value = StringRef()) const;
	LLVM_NODISCARD AttributeList			LLVM_NODISCARD AttributeList
	addAttribute(LLVMContext &C, unsigned Index, StringRef Kind,			addAttribute(LLVMContext &C, unsigned Index, StringRef Kind,
	StringRef Value = StringRef()) const {			StringRef Value = StringRef()) const {
	return addAttributeAtIndex(C, Index, Kind);			return addAttributeAtIndex(C, Index, Kind, Value);
	}			}

	/// Add an attribute to the attribute set at the given index.			/// Add an attribute to the attribute set at the given index.
	/// Returns a new list because attribute lists are immutable.			/// Returns a new list because attribute lists are immutable.
	LLVM_NODISCARD AttributeList addAttributeAtIndex(LLVMContext &C,			LLVM_NODISCARD AttributeList addAttributeAtIndex(LLVMContext &C,
	unsigned Index,			unsigned Index,
	Attribute A) const;			Attribute A) const;
	LLVM_NODISCARD AttributeList addAttribute(LLVMContext &C, unsigned Index,			LLVM_NODISCARD AttributeList addAttribute(LLVMContext &C, unsigned Index,
	▲ Show 20 Lines • Show All 728 Lines • Show Last 20 Lines