Page MenuHomePhabricator

zsrkmyn (Senran Zhang)
User

Projects

User does not belong to any projects.

User Details

User Since
May 22 2019, 7:11 PM (168 w, 3 d)

Recent Activity

Jun 15 2022

zsrkmyn abandoned D127857: [NFC][TableGen] Optimize DecoderEmmitter.
Jun 15 2022, 7:07 AM · Restricted Project, Restricted Project
zsrkmyn requested review of D127857: [NFC][TableGen] Optimize DecoderEmmitter.
Jun 15 2022, 7:05 AM · Restricted Project, Restricted Project

Apr 23 2022

zsrkmyn committed rGae76eb32a598: [NFC][Clang][Pragma] Remove unused variables (authored by zsrkmyn).
[NFC][Clang][Pragma] Remove unused variables
Apr 23 2022, 11:51 PM · Restricted Project, Restricted Project
zsrkmyn closed D124339: [NFC][Clang][Pragma] Remove unused variables.
Apr 23 2022, 11:51 PM · Restricted Project, Restricted Project
zsrkmyn added reviewers for D124339: [NFC][Clang][Pragma] Remove unused variables: MaskRay, beanz.
Apr 23 2022, 7:55 PM · Restricted Project, Restricted Project
zsrkmyn requested review of D124339: [NFC][Clang][Pragma] Remove unused variables.
Apr 23 2022, 7:53 PM · Restricted Project, Restricted Project

Apr 7 2022

zsrkmyn committed rGa23652f6f9d8: [demangler] Support C23 _BitInt type (authored by zsrkmyn).
[demangler] Support C23 _BitInt type
Apr 7 2022, 9:21 PM · Restricted Project, Restricted Project
zsrkmyn closed D122530: [demangler] Support C23 _BitInt type.
Apr 7 2022, 9:21 PM · Restricted Project, Restricted Project, Restricted Project
zsrkmyn updated the diff for D122530: [demangler] Support C23 _BitInt type.

Rebase to the latest commit

Apr 7 2022, 8:00 PM · Restricted Project, Restricted Project, Restricted Project

Apr 5 2022

zsrkmyn added a comment to D122530: [demangler] Support C23 _BitInt type.

A soft ping.

Apr 5 2022, 6:58 PM · Restricted Project, Restricted Project, Restricted Project

Mar 30 2022

zsrkmyn added reviewers for D122530: [demangler] Support C23 _BitInt type: phosek, EricWF, compnerd.
Mar 30 2022, 9:32 PM · Restricted Project, Restricted Project, Restricted Project

Mar 29 2022

zsrkmyn added a comment to D122530: [demangler] Support C23 _BitInt type.

@ldionne, may I get your comments or approval? Thanks!

Mar 29 2022, 7:48 PM · Restricted Project, Restricted Project, Restricted Project

Mar 28 2022

zsrkmyn added a comment to D122530: [demangler] Support C23 _BitInt type.

I wonder if there is value, for backwards compatibility to ALSO parse the old _ExtInt mangling?

@erichkeane, I'm not sure what _ExtInt was mangled to in the past, but it now is also mangled as DB/DU using the latest clang, so it's enough to demangle DB and DU IMO.

I went to look it up, we used to mangle it as a 'struct', so it demangled anyway (so _ExtInt13 was : U7_ExtIntILi13, so void foo(_ExtInt(13)) was _Z3fooU7_ExtIntILi13EEi.

Mar 28 2022, 7:58 AM · Restricted Project, Restricted Project, Restricted Project
zsrkmyn added a comment to D122530: [demangler] Support C23 _BitInt type.

I wonder if there is value, for backwards compatibility to ALSO parse the old _ExtInt mangling?

Mar 28 2022, 7:42 AM · Restricted Project, Restricted Project, Restricted Project
zsrkmyn updated the diff for D122530: [demangler] Support C23 _BitInt type.
Mar 28 2022, 7:36 AM · Restricted Project, Restricted Project, Restricted Project
zsrkmyn updated the diff for D122530: [demangler] Support C23 _BitInt type.
Mar 28 2022, 7:31 AM · Restricted Project, Restricted Project, Restricted Project

Mar 27 2022

zsrkmyn updated the diff for D122530: [demangler] Support C23 _BitInt type.

Update match function

Mar 27 2022, 7:57 PM · Restricted Project, Restricted Project, Restricted Project
zsrkmyn added a comment to D122530: [demangler] Support C23 _BitInt type.

Thank you for this! It looks correct to me, but the changes should probably come with some test coverage as well.

Mar 27 2022, 7:50 AM · Restricted Project, Restricted Project, Restricted Project

Mar 26 2022

zsrkmyn added reviewers for D122530: [demangler] Support C23 _BitInt type: ldionne, erichkeane, aaron.ballman, pengfei, MaskRay, urnathan, rsmith.
Mar 26 2022, 10:11 AM · Restricted Project, Restricted Project, Restricted Project
zsrkmyn requested review of D122530: [demangler] Support C23 _BitInt type.
Mar 26 2022, 10:02 AM · Restricted Project, Restricted Project, Restricted Project

Nov 18 2021

zsrkmyn added a comment to D114131: [NFC][OpaquePtr][Evaluator] Remove PointerType::getElementType.

0425ea462197e605d597719f1630c68dbcc25ed8

Nov 18 2021, 6:38 PM · Restricted Project
zsrkmyn committed rG0425ea462197: [NFC][OpaquePtr][Evaluator] Remove call to PointerType::getElementType (authored by zsrkmyn).
[NFC][OpaquePtr][Evaluator] Remove call to PointerType::getElementType
Nov 18 2021, 6:34 PM
zsrkmyn closed D114131: [NFC][OpaquePtr][Evaluator] Remove PointerType::getElementType.
Nov 18 2021, 6:34 PM · Restricted Project

Nov 17 2021

zsrkmyn requested review of D114131: [NFC][OpaquePtr][Evaluator] Remove PointerType::getElementType.
Nov 17 2021, 5:39 PM · Restricted Project

Sep 1 2021

zsrkmyn added a comment to D109132: Fix missing argument introduced by D108788.

Could you help land the patch? I don't have write access. Many thanks!

Sep 1 2021, 10:58 PM · Restricted Project
zsrkmyn added inline comments to D108788: [NFC] Rename attribute methods that work with indexes.
Sep 1 2021, 10:52 PM · Restricted Project
zsrkmyn requested review of D109132: Fix missing argument introduced by D108788.
Sep 1 2021, 10:51 PM · Restricted Project
zsrkmyn added inline comments to D108788: [NFC] Rename attribute methods that work with indexes.
Sep 1 2021, 10:43 PM · Restricted Project

Aug 18 2021

zsrkmyn abandoned D108041: [LTO] Add --lto-pgo-warn-mismatch support for legacy PM.

I'm OK not merging this.

Aug 18 2021, 8:28 PM · Restricted Project

Aug 13 2021

zsrkmyn requested review of D108041: [LTO] Add --lto-pgo-warn-mismatch support for legacy PM.
Aug 13 2021, 8:20 AM · Restricted Project

Aug 11 2021

zsrkmyn added a comment to D104431: [LTO][lld] Add lto-pgo-warn-mismatch option.

I met the same issue. It may be fixed by the following patch.

Aug 11 2021, 2:20 AM · Restricted Project

Aug 3 2021

zsrkmyn added a comment to D107252: [NFC][ConstantFold] Check getAggregateElement before getSplatValue call.

Would you mind helping me commit it if there's no further comments? Many thanks :-)

Aug 3 2021, 8:43 PM · Restricted Project

Aug 2 2021

zsrkmyn added a comment to D106334: Initialize common options in `getRegisteredOptions`.

Would you mind helping me commit it if there's no further comments? Many thanks!

Aug 2 2021, 6:23 PM · Restricted Project
zsrkmyn updated the diff for D106334: Initialize common options in `getRegisteredOptions`.
Aug 2 2021, 6:21 PM · Restricted Project
zsrkmyn requested review of D107252: [NFC][ConstantFold] Check getAggregateElement before getSplatValue call.
Aug 2 2021, 1:43 AM · Restricted Project
zsrkmyn added inline comments to D106334: Initialize common options in `getRegisteredOptions`.
Aug 2 2021, 12:54 AM · Restricted Project

Aug 1 2021

zsrkmyn added a comment to D106334: Initialize common options in `getRegisteredOptions`.

A soft ping.

Aug 1 2021, 7:23 PM · Restricted Project

Jul 27 2021

zsrkmyn added a comment to D106751: [OpenMP][Libomptarget] Adding `print_device_info` to RTL and `omptarget`.

Thanks for quickly fixing it :-)

Jul 27 2021, 10:49 PM · Restricted Project
zsrkmyn added inline comments to D106751: [OpenMP][Libomptarget] Adding `print_device_info` to RTL and `omptarget`.
Jul 27 2021, 9:05 PM · Restricted Project
zsrkmyn added inline comments to D106751: [OpenMP][Libomptarget] Adding `print_device_info` to RTL and `omptarget`.
Jul 27 2021, 8:35 PM · Restricted Project
zsrkmyn added inline comments to D106751: [OpenMP][Libomptarget] Adding `print_device_info` to RTL and `omptarget`.
Jul 27 2021, 8:19 PM · Restricted Project

Jul 26 2021

zsrkmyn added a comment to D106334: Initialize common options in `getRegisteredOptions`.

Test added ;-)

Jul 26 2021, 5:28 AM · Restricted Project
zsrkmyn updated the diff for D106334: Initialize common options in `getRegisteredOptions`.
Jul 26 2021, 5:27 AM · Restricted Project

Jul 20 2021

zsrkmyn added a comment to D106334: Initialize common options in `getRegisteredOptions`.

I'm guessing even if it were, it might not solve our problems though, since the variables are local statics, so resetting wouldn't cause them to be reinstantiated...

Jul 20 2021, 1:08 AM · Restricted Project

Jul 19 2021

zsrkmyn added a comment to D106334: Initialize common options in `getRegisteredOptions`.

I'm not sure if we need a test for it. I tried to add one but the test passed even without this patch, as those options were already initialized before running the test.

Jul 19 2021, 7:40 PM · Restricted Project
zsrkmyn requested review of D106334: Initialize common options in `getRegisteredOptions`.
Jul 19 2021, 7:38 PM · Restricted Project

May 16 2021

zsrkmyn added a comment to D101135: [Utils][vim] Highlight CHECK-EMPTY: & CHECK-COUNT: directives.

Would you mind helping me commit this patch if there's no further comment? Thanks :-)

May 16 2021, 6:40 PM · Restricted Project

May 12 2021

zsrkmyn updated the diff for D101135: [Utils][vim] Highlight CHECK-EMPTY: & CHECK-COUNT: directives.
May 12 2021, 1:38 AM · Restricted Project

Apr 25 2021

zsrkmyn added a comment to D101135: [Utils][vim] Highlight CHECK-EMPTY: & CHECK-COUNT: directives.

Note, many prefixes are not called CHECK*...

Apr 25 2021, 8:41 PM · Restricted Project

Apr 22 2021

zsrkmyn requested review of D101135: [Utils][vim] Highlight CHECK-EMPTY: & CHECK-COUNT: directives.
Apr 22 2021, 11:08 PM · Restricted Project

Mar 19 2021

zsrkmyn added a comment to D98927: [Utils][vim] Highlight `poison` keyword.

Would you mind helping me commit it? Thanks! :-D

Mar 19 2021, 6:51 PM · Restricted Project
zsrkmyn requested review of D98927: [Utils][vim] Highlight `poison` keyword.
Mar 19 2021, 12:56 AM · Restricted Project

Apr 20 2020

Herald added a reviewer for D63291: [RFC] Initial patch to support IR extensions for annotating directive region entry/exit : jdoerfert.
Apr 20 2020, 1:34 AM · Restricted Project

Nov 25 2019

zsrkmyn updated the diff for D70671: [clang][CodeGen] Fix wrong memcpy size of no_unique_address in FieldMemcpyizer.

Thanks for reviewing! Would you mind helping me commit this patch? Thanks :-D

Nov 25 2019, 5:43 PM · Restricted Project
zsrkmyn added a reviewer for D70671: [clang][CodeGen] Fix wrong memcpy size of no_unique_address in FieldMemcpyizer: rsmith.
Nov 25 2019, 9:14 AM · Restricted Project
zsrkmyn created D70671: [clang][CodeGen] Fix wrong memcpy size of no_unique_address in FieldMemcpyizer.
Nov 25 2019, 7:06 AM · Restricted Project

Sep 10 2019

zsrkmyn added a comment to D67058: [clang][CodeGen] Add alias for cpu_dispatch function with IFunc & Fix resolver linkage type.

All done IMO. :-) Thank Erich a lot for reviewing! Would you mind helping me commit it?

Sep 10 2019, 10:55 AM · Restricted Project, Restricted Project
zsrkmyn updated the diff for D67058: [clang][CodeGen] Add alias for cpu_dispatch function with IFunc & Fix resolver linkage type.
Sep 10 2019, 10:44 AM · Restricted Project, Restricted Project
zsrkmyn added inline comments to D67058: [clang][CodeGen] Add alias for cpu_dispatch function with IFunc & Fix resolver linkage type.
Sep 10 2019, 9:19 AM · Restricted Project, Restricted Project
zsrkmyn added inline comments to D67058: [clang][CodeGen] Add alias for cpu_dispatch function with IFunc & Fix resolver linkage type.
Sep 10 2019, 8:46 AM · Restricted Project, Restricted Project
zsrkmyn added inline comments to D67058: [clang][CodeGen] Add alias for cpu_dispatch function with IFunc & Fix resolver linkage type.
Sep 10 2019, 2:13 AM · Restricted Project, Restricted Project

Sep 7 2019

zsrkmyn added a comment to D67206: [ELF][MC] Fix IFunc alias resolving issue.

Thank @MaskRay for reviewing. Would you mind helping me commit it? :-)

Sep 7 2019, 6:25 AM · Restricted Project
zsrkmyn added inline comments to D67058: [clang][CodeGen] Add alias for cpu_dispatch function with IFunc & Fix resolver linkage type.
Sep 7 2019, 12:50 AM · Restricted Project, Restricted Project
zsrkmyn updated the diff for D67206: [ELF][MC] Fix IFunc alias resolving issue.
Sep 7 2019, 12:27 AM · Restricted Project

Sep 6 2019

zsrkmyn added inline comments to D67058: [clang][CodeGen] Add alias for cpu_dispatch function with IFunc & Fix resolver linkage type.
Sep 6 2019, 8:16 AM · Restricted Project, Restricted Project
zsrkmyn updated the diff for D67206: [ELF][MC] Fix IFunc alias resolving issue.
Sep 6 2019, 1:57 AM · Restricted Project
zsrkmyn updated the diff for D67206: [ELF][MC] Fix IFunc alias resolving issue.
Sep 6 2019, 1:55 AM · Restricted Project
zsrkmyn updated the diff for D67206: [ELF][MC] Fix IFunc alias resolving issue.
Sep 6 2019, 12:53 AM · Restricted Project

Sep 5 2019

zsrkmyn added inline comments to D67058: [clang][CodeGen] Add alias for cpu_dispatch function with IFunc & Fix resolver linkage type.
Sep 5 2019, 8:35 PM · Restricted Project, Restricted Project
zsrkmyn added inline comments to D67058: [clang][CodeGen] Add alias for cpu_dispatch function with IFunc & Fix resolver linkage type.
Sep 5 2019, 7:45 PM · Restricted Project, Restricted Project

Sep 4 2019

zsrkmyn updated the diff for D67058: [clang][CodeGen] Add alias for cpu_dispatch function with IFunc & Fix resolver linkage type.
Sep 4 2019, 8:31 PM · Restricted Project, Restricted Project
zsrkmyn added inline comments to D67206: [ELF][MC] Fix IFunc alias resolving issue.
Sep 4 2019, 8:02 PM · Restricted Project
zsrkmyn added inline comments to D67058: [clang][CodeGen] Add alias for cpu_dispatch function with IFunc & Fix resolver linkage type.
Sep 4 2019, 7:47 PM · Restricted Project, Restricted Project
zsrkmyn added a comment to D67206: [ELF][MC] Fix IFunc alias resolving issue.

Suppose we have foo.s as follows:

Sep 4 2019, 6:30 PM · Restricted Project
zsrkmyn created D67206: [ELF][MC] Fix IFunc alias resolving issue.
Sep 4 2019, 6:29 PM · Restricted Project
zsrkmyn added inline comments to D67058: [clang][CodeGen] Add alias for cpu_dispatch function with IFunc & Fix resolver linkage type.
Sep 4 2019, 6:06 AM · Restricted Project, Restricted Project

Sep 2 2019

zsrkmyn added a comment to D67058: [clang][CodeGen] Add alias for cpu_dispatch function with IFunc & Fix resolver linkage type.

Thanks @lebedev.ri , I'm currently under discussion with @erichkeane , and I'll add lit test after the final decision on how to solve the issue.

Sep 2 2019, 7:14 PM · Restricted Project, Restricted Project

Sep 1 2019

zsrkmyn created D67058: [clang][CodeGen] Add alias for cpu_dispatch function with IFunc & Fix resolver linkage type.
Sep 1 2019, 8:10 PM · Restricted Project, Restricted Project

Aug 21 2019

zsrkmyn added a comment to D66458: [COFF] Fix section name for constants larger than 64 bits on Windows.

Changed according to MaskRay's comment.
BTW, I cannot commit the patch myself. Can someone help commit it? Thanks a lot!

Aug 21 2019, 6:31 PM · Restricted Project
zsrkmyn updated the diff for D66458: [COFF] Fix section name for constants larger than 64 bits on Windows.
Aug 21 2019, 6:29 PM · Restricted Project
zsrkmyn added a reviewer for D63061: [builtins] Fix overflow issue for complex division with big numbers: ddunbar.
Aug 21 2019, 8:02 AM · Restricted Project, Restricted Project
zsrkmyn added a comment to D63061: [builtins] Fix overflow issue for complex division with big numbers.

ping

Aug 21 2019, 8:02 AM · Restricted Project, Restricted Project
zsrkmyn added reviewers for D66458: [COFF] Fix section name for constants larger than 64 bits on Windows: craig.topper, rnk, annita.zhang, LuoYuanke.
Aug 21 2019, 7:55 AM · Restricted Project

Aug 19 2019

zsrkmyn created D66458: [COFF] Fix section name for constants larger than 64 bits on Windows.
Aug 19 2019, 6:47 PM · Restricted Project

Jul 9 2019

zsrkmyn added reviewers for D63061: [builtins] Fix overflow issue for complex division with big numbers: nsz, phosek.
Jul 9 2019, 10:02 PM · Restricted Project, Restricted Project

Jun 9 2019

zsrkmyn created D63061: [builtins] Fix overflow issue for complex division with big numbers.
Jun 9 2019, 9:58 AM · Restricted Project, Restricted Project