This is an archive of the discontinued LLVM Phabricator instance.

[flang] Move runtime API headers to flang/include/flang/Runtime
ClosedPublic

Authored by klausler on Sep 1 2021, 4:16 PM.

Details

Summary

Move the closure of the subset of flang/runtime/*.h header files that
are referenced by source files outside flang/runtime (apart from unit tests)
into a new directory (flang/include/flang/Runtime) so that relative
include paths into ../runtime need not be used.

flang/runtime/pgmath.h.inc is moved to flang/include/flang/Evaluate;
it's not used by the runtime.

Diff Detail

Unit TestsFailed

Event Timeline

klausler created this revision.Sep 1 2021, 4:16 PM
klausler requested review of this revision.Sep 1 2021, 4:16 PM
jeanPerier added inline comments.Sep 2 2021, 1:16 AM
flang/test/Runtime/no-cpp-dep.c
11

I could reproduce the buildbot failure for this test.

This file is different from the others because it is not built by CMAKE, it is built by LIT with the command in the RUN:. So the %runtimeincludes definition in lit.cfg.py needs to be fixed here.

I guess you can decide between leaving this test untouched and replacing runtime by include/flang/Runtime in the lit.cfg.py, or keeping this change and replacing runtime by include in the lit.cfg.py.

klausler updated this revision to Diff 370291.Sep 2 2021, 9:19 AM

Update flang/test/lit.cfg.py to point to flang/include for flang/test/Runtime/*.c.

klausler added inline comments.Sep 2 2021, 11:04 AM
flang/test/Runtime/no-cpp-dep.c
11

Fixed.

jeanPerier accepted this revision.Sep 2 2021, 10:59 PM
This revision is now accepted and ready to land.Sep 2 2021, 10:59 PM
This revision was landed with ongoing or failed builds.Sep 3 2021, 11:08 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptSep 3 2021, 11:08 AM