Page MenuHomePhabricator

[mlir][tosa] Quantized tosa.avg_pool2d lowering to linalg
ClosedPublic

Authored by rsuderman on Aug 24 2021, 5:00 PM.

Details

Summary

Includes the quantized version of average pool lowering to linalg dialect.
This includes a lit test for the transform. It is not 100% correct as the
multiplier / shift should be done in i64 however this is negligable rounding
difference.

Diff Detail

Event Timeline

rsuderman created this revision.Aug 24 2021, 5:00 PM
rsuderman requested review of this revision.Aug 24 2021, 5:01 PM
NatashaKnk accepted this revision.Aug 24 2021, 5:55 PM
NatashaKnk added inline comments.
mlir/lib/Conversion/TosaToLinalg/TosaToLinalg.cpp
2596

Was this missed or is it for future reference?

This revision is now accepted and ready to land.Aug 24 2021, 5:55 PM
rsuderman updated this revision to Diff 368517.Aug 24 2021, 6:06 PM

Remove comment and move atribute.

rsuderman updated this revision to Diff 368523.Aug 24 2021, 6:23 PM

Rebased on head.

rsuderman marked an inline comment as done.Aug 24 2021, 6:25 PM
rsuderman added inline comments.
mlir/lib/Conversion/TosaToLinalg/TosaToLinalg.cpp
2596

Removed. Initially I thought I could reduce the work but it actually was unnecessary.

This revision was automatically updated to reflect the committed changes.
rsuderman marked an inline comment as done.