Page MenuHomePhabricator

[OpenMP][amdgcn] Don't use in-tree clang if not available.
ClosedPublic

Authored by Meinersbur on Aug 24 2021, 10:00 AM.

Details

Summary

The use of $<TARGET_FILE:clang> was adapted too broadly from D101265.

Fixes llvm.org/PR51579

Also see discussion in D108534.

Diff Detail

Event Timeline

Meinersbur created this revision.Aug 24 2021, 10:00 AM
Meinersbur requested review of this revision.Aug 24 2021, 10:00 AM
JonChesterfield accepted this revision.Aug 24 2021, 10:08 AM

Looks reasonable to me, thanks!

This revision is now accepted and ready to land.Aug 24 2021, 10:08 AM
bondhugula added inline comments.Aug 24 2021, 10:24 AM
openmp/libomptarget/deviceRTLs/amdgcn/CMakeLists.txt
53

Nit: Missing full stop at the end.

Meinersbur added inline comments.Aug 25 2021, 7:32 AM
openmp/libomptarget/deviceRTLs/amdgcn/CMakeLists.txt
53

Neither do the other libomptarget_say calls. Just keeping it consistent.