[InstCombine][NFC] refactor roundtripcast
AcceptedPublic
Actions

Authored by Krishnakariya on Aug 20 2021, 11:57 PM.

Details

Reviewers

nlopes
aqjune
spatel
nikic
lebedev.ri

Summary

Split from D107822.
Refactoring "simplifyIntToPtrRoundTripCast" and "isIntToPtrRoundTripCast".

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

Krishnakariya created this revision.Aug 20 2021, 11:57 PM

Herald added subscribers: hiraditya, arichardson. · View Herald TranscriptAug 20 2021, 11:57 PM

Krishnakariya requested review of this revision.Aug 20 2021, 11:57 PM

Herald added a project: Restricted Project. · View Herald TranscriptAug 20 2021, 11:57 PM

Herald added a subscriber: llvm-commits. · View Herald Transcript

Krishnakariya added a child revision: D107822: [InstCombine] Fold Int2Ptr/PtrToInt if the ptr is dereferenceable.Aug 20 2021, 11:58 PM

Krishnakariya added reviewers: nlopes, aqjune, spatel, nikic, lebedev.ri.

Harbormaster completed remote builds in B120662: Diff 367943.Aug 21 2021, 12:36 AM

Krishnakariya added a child revision: D108506: [InstCombine] Fold Int2Ptr/PtrToInt if the ptr is dereferenceable using API.Aug 21 2021, 1:27 AM

Krishnakariya removed a child revision: D107822: [InstCombine] Fold Int2Ptr/PtrToInt if the ptr is dereferenceable.

In terms of correctness, I think the patch looks okay.

Krishnakariya mentioned this in D107822: [InstCombine] Fold Int2Ptr/PtrToInt if the ptr is dereferenceable.Aug 21 2021, 2:38 AM

nlopes accepted this revision.Sep 1 2021, 5:33 AM

This revision is now accepted and ready to land.Sep 1 2021, 5:33 AM

This review seems to be stuck/dead, consider abandoning if no longer relevant.

Herald added a project: Restricted Project. · View Herald TranscriptJan 12 2023, 5:42 PM

Herald added a subscriber: StephenFan. · View Herald Transcript

Revision Contents
Changeset List

Path

Size

llvm/

lib/

Transforms/

InstCombine/

InstCombineInternal.h

1 line

InstructionCombining.cpp

11 lines

Diff 367943

View Options

llvm/lib/Transforms/InstCombine/InstCombineInternal.h