- User Since
- Apr 7 2021, 7:29 AM (103 w, 3 d)
Aug 21 2021
Aug 20 2021
Aug 18 2021
Aug 12 2021
Aug 11 2021
Modified code and Added new tests
Aug 10 2021
Aug 9 2021
Aug 7 2021
Updating the same diff to commit this patch.
Aug 3 2021
I committed this patch by mistake. I am extremely sorry about this.
I've reverted the commit.
Aug 2 2021
Updated diff after pre-committing tests.
Aug 1 2021
Jul 31 2021
Added new tests
Jul 30 2021
Yes, it handles this case. I have added a new test for the same.
Jul 28 2021
Added a test for different input pointer types (func_pointer_different_types).
Jul 27 2021
Sure, I have updated the description.
Jul 26 2021
Jul 24 2021
Yes, we may remove FMF checks as below. I will make a new patch for this.
FSub logic: Remove check for nnan flag presence in fsub instruction. Example: https://alive2.llvm.org/ce/z/tYeZub (fsub).
FNeg logic: Remove check for the presence of nnan and nsz flag in fneg instruction. Example: https://alive2.llvm.org/ce/z/TbuLnk (fneg), https://alive2.llvm.org/ce/z/yBDCZ_ (fsub).
Jul 22 2021
Could you please commit this patch for me? I do not have commit access yet.
I am sorry for my delayed responses to this patch. I wanted to ask for some clarification on your previous comments.
I have created few new tests similar to the original ones, with the only change that the FMF flag present in the fsub/fneg is now present on the select instruction. Original tests are left untouched.
Is this what you were expecting in your last comment?
Jul 20 2021
Jul 19 2021
Jul 17 2021
Jul 15 2021
simplified code for function "foldICmpWithCastOp".
Ping @spatel, a gentle reminder. Could you please review the updates on this patch?
Jul 14 2021
Created a new function (simplifyIntToPtrRoundTripCast) which simplifies the inttoptr/ptrtoint cast.
Jul 13 2021
Jul 12 2021
I do not have commit access. Please commit this patch for me.
Modified test3 and updated the names of unit tests.
Jul 11 2021
Jul 9 2021
Added an command-line option disable-i2p-p2i-opt to opt to disable inttoptr/ptrtoint optimization.
I have removed the const keyword from the declaration of the CastResults array.
This change is temporary, and the array would be constified again.
Jul 8 2021
Jul 7 2021
Updated the check.
- Added check for nnan (earlier removed) and added new tests.
- Check for nsz in select for fneg logic is required. So, I didn't remove this check. Please see this example: https://alive2.llvm.org/ce/z/sEfTYx.
Jul 6 2021
Added the check and test case for the same.
Jul 4 2021
Jun 29 2021
Jun 14 2021
This patch is complete and is ready for review.
Jun 3 2021
I have made changes in FMF propagation logic.
FMF like nnan and ninf should be propagated only if present in select instruction, while for other flags like arcp, reassoc, it doesn't really depend on select instruction.
May 14 2021
Added description for the test case.