The test case is not ran unless libcxx is used, and a macro
may be undefined. This patch checks for the definition of the
macro before using it.
Details
Details
- Reviewers
nemanjai saghir Mordante ldionne - Group Reviewers
Restricted Project Restricted Project - Commits
- rG4bef7a8ff169: [libc++][PowerPC] Fix a test case failure when compiled with libcxx
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
LGTM mod comment.
libcxx/test/std/numerics/numeric.ops/numeric.ops.midpoint/midpoint.float.pass.cpp | ||
---|---|---|
95 | Please De-Morgan-ize this condition, for readability. Make it: #if defined(__PPC__) && __LONG_DOUBLE_128__ && !(defined(__LONG_DOUBLE_IEEE128__) && __LONG_DOUBLE_IEEE128__) |
Comment Actions
Please update the description of this patch to address @ldionne's review comment https://reviews.llvm.org/D108071#2950754
Other than that and @Quuxplusone's comment LGTM.
libcxx/test/std/numerics/numeric.ops/numeric.ops.midpoint/midpoint.float.pass.cpp | ||
---|---|---|
95 | updated, thanks! |
Comment Actions
LGTM, I'll commit this (and reference http://llvm.org/PR51430 in the commit message), and cherry-pick it to release/13.x
Please De-Morgan-ize this condition, for readability. Make it: