This is an archive of the discontinued LLVM Phabricator instance.

[Attributor][FIX] Recursion via memory needs to be tracked explicitly
ClosedPublic

Authored by jdoerfert on Aug 16 2021, 11:39 PM.

Details

Summary

Recursion can happen when we see a PHI use the second time or when we
look at a store value operand use again. We already visited the
potential copies and doing so again will just cause endless looping.

Diff Detail

Event Timeline

jdoerfert created this revision.Aug 16 2021, 11:39 PM
jdoerfert requested review of this revision.Aug 16 2021, 11:39 PM
Herald added a reviewer: baziotis. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
kuter accepted this revision.Aug 17 2021, 11:59 AM

LGTM

This revision is now accepted and ready to land.Aug 17 2021, 11:59 AM
This revision was landed with ongoing or failed builds.Aug 27 2021, 11:12 AM
This revision was automatically updated to reflect the committed changes.