This is an archive of the discontinued LLVM Phabricator instance.

Differential D108182

Allow setting attributes in build method generated by YAML-gen.
ClosedPublic

Authored by mravishankar on Aug 16 2021, 8:26 PM.

Details

Reviewers
nicolasvasilache
gysit
rsuderman
Commits
rG836649e04040: Allow setting attributes in build method generated by YAML-gen.

Diff Detail

Event Timeline

mravishankar created this revision.Aug 16 2021, 8:26 PM
Herald added subscribers: wrengr, Chia-hungDuan, dcaballe and 18 others. · View Herald TranscriptAug 16 2021, 8:26 PM
mravishankar requested review of this revision.Aug 16 2021, 8:26 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 16 2021, 8:26 PM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
mravishankar added reviewers: nicolasvasilache, gysit, rsuderman.Aug 16 2021, 8:26 PM
Harbormaster completed remote builds in B119824: Diff 366794.Aug 16 2021, 8:50 PM
gysit accepted this revision.Aug 17 2021, 1:13 AM
gysit added inline comments.
mlir/tools/mlir-linalg-ods-gen/mlir-linalg-ods-yaml-gen.cpp
463

Off-topic but i believe this builder should also set the result types. I will take care of this in a follow up revision.

This revision is now accepted and ready to land.Aug 17 2021, 1:13 AM
Closed by commit rG836649e04040: Allow setting attributes in build method generated by YAML-gen. (authored by mravishankar). · Explain WhyAug 17 2021, 9:10 AM
This revision was automatically updated to reflect the committed changes.
mravishankar added a commit: rG836649e04040: Allow setting attributes in build method generated by YAML-gen..

Revision Contents

PathSize
mlir/
tools/
mlir-linalg-ods-gen/
4 lines

Diff 366919

mlir/tools/mlir-linalg-ods-gen/mlir-linalg-ods-yaml-gen.cpp

Show First 20 Lines • Show All 454 Lines • ▼ Show 20 Lines /*extraInterfaces=*/[{2}])> {
let regions = (region AnyRegion:$region); let regions = (region AnyRegion:$region);
let skipDefaultBuilders = 1; let skipDefaultBuilders = 1;
let builders = [ let builders = [
OpBuilder< OpBuilder<
(ins "ValueRange":$inputs, "ValueRange":$outputs), (ins "ValueRange":$inputs, "ValueRange":$outputs),
[{{ [{{
$_state.addOperands(inputs); $_state.addOperands(inputs);
$_state.addOperands(outputs); $_state.addOperands(outputs);
gysitUnsubmitted
Not Done
ReplyInline Actions

Off-topic but i believe this builder should also set the result types. I will take care of this in a follow up revision.

gysit: Off-topic but i believe this builder should also set the result types. I will take care of this…
$_state.addAttribute( $_state.addAttribute(
"operand_segment_sizes", "operand_segment_sizes",
$_builder.getI32VectorAttr({{ $_builder.getI32VectorAttr({{
static_cast<int32_t>(inputs.size()), static_cast<int32_t>(inputs.size()),
static_cast<int32_t>(outputs.size())})); static_cast<int32_t>(outputs.size())}));
createAndFillStructuredOpRegion<{0}>( createAndFillStructuredOpRegion<{0}>(
$_builder, $_builder,
$_state, $_state,
TypeRange(inputs), TypeRange(inputs),
TypeRange(outputs)); TypeRange(outputs));
}]>, }]>,
OpBuilder< OpBuilder<
(ins "TypeRange":$resultTensorTypes, "ValueRange":$inputs, (ins "TypeRange":$resultTensorTypes, "ValueRange":$inputs,
"ValueRange":$outputs), "ValueRange":$outputs,
CArg<"ArrayRef<NamedAttribute>", "{{}">:$attributes),
[{{ [{{
$_state.addOperands(inputs); $_state.addOperands(inputs);
$_state.addOperands(outputs); $_state.addOperands(outputs);
$_state.addTypes(resultTensorTypes); $_state.addTypes(resultTensorTypes);
$_state.addAttributes(attributes);
$_state.addAttribute( $_state.addAttribute(
"operand_segment_sizes", "operand_segment_sizes",
$_builder.getI32VectorAttr({{ $_builder.getI32VectorAttr({{
static_cast<int32_t>(inputs.size()), static_cast<int32_t>(inputs.size()),
static_cast<int32_t>(outputs.size())})); static_cast<int32_t>(outputs.size())}));
createAndFillStructuredOpRegion<{0}>( createAndFillStructuredOpRegion<{0}>(
$_builder, $_builder,
$_state, $_state,
▲ Show 20 Lines • Show All 619 Lines • Show Last 20 Lines