This is an archive of the discontinued LLVM Phabricator instance.

Differential D108170

[Attributor][FIX] AAPointerInfo fix uninitialized usage.
AcceptedPublic

Authored by kuter on Aug 16 2021, 4:31 PM.

Details

Reviewers
uenoku
homerdin
jdoerfert
sstefan1
baziotis
Summary

Valgrind complains about AAPoineterInfo::handleAccess branching
on a uninitialized variable. This patch fixes the problem.

Diff Detail

Event Timeline

kuter created this revision.Aug 16 2021, 4:31 PM
Herald added a reviewer: uenoku. · View Herald TranscriptAug 16 2021, 4:31 PM
Herald added a reviewer: homerdin. · View Herald Transcript
Herald added subscribers: ormris, okura, jdoerfert and 2 others. · View Herald Transcript
kuter requested review of this revision.Aug 16 2021, 4:31 PM
Herald added a reviewer: jdoerfert. · View Herald TranscriptAug 16 2021, 4:31 PM
Herald added a reviewer: sstefan1. · View Herald Transcript
Herald added a reviewer: baziotis. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B119803: Diff 366764.Aug 16 2021, 4:58 PM
jdoerfert accepted this revision.Aug 16 2021, 10:08 PM

LG, feel free to commit these.

This revision is now accepted and ready to land.Aug 16 2021, 10:08 PM

Revision Contents

PathSize
llvm/
lib/
Transforms/
IPO/
2 lines

Diff 366764

llvm/lib/Transforms/IPO/AttributorAttributes.cpp

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 1,377 Lines • ▼ Show 20 Lines ChangeStatus updateImpl(Attributor &A) override {
// accessed. // accessed.
if (auto *MI = dyn_cast_or_null<MemIntrinsic>(getCtxI())) { if (auto *MI = dyn_cast_or_null<MemIntrinsic>(getCtxI())) {
ConstantInt *Length = dyn_cast<ConstantInt>(MI->getLength()); ConstantInt *Length = dyn_cast<ConstantInt>(MI->getLength());
int64_t LengthVal = OffsetAndSize::Unknown; int64_t LengthVal = OffsetAndSize::Unknown;
if (Length) if (Length)
LengthVal = Length->getSExtValue(); LengthVal = Length->getSExtValue();
Value &Ptr = getAssociatedValue(); Value &Ptr = getAssociatedValue();
unsigned ArgNo = getIRPosition().getCallSiteArgNo(); unsigned ArgNo = getIRPosition().getCallSiteArgNo();
ChangeStatus Changed; ChangeStatus Changed = ChangeStatus::UNCHANGED;
if (ArgNo == 0) { if (ArgNo == 0) {
handleAccess(A, *MI, Ptr, nullptr, AccessKind::AK_WRITE, 0, Changed, handleAccess(A, *MI, Ptr, nullptr, AccessKind::AK_WRITE, 0, Changed,
nullptr, LengthVal); nullptr, LengthVal);
} else if (ArgNo == 1) { } else if (ArgNo == 1) {
handleAccess(A, *MI, Ptr, nullptr, AccessKind::AK_READ, 0, Changed, handleAccess(A, *MI, Ptr, nullptr, AccessKind::AK_READ, 0, Changed,
nullptr, LengthVal); nullptr, LengthVal);
} else { } else {
LLVM_DEBUG(dbgs() << "[AAPointerInfo] Unhandled memory intrinsic " LLVM_DEBUG(dbgs() << "[AAPointerInfo] Unhandled memory intrinsic "
▲ Show 20 Lines • Show All 8,351 Lines • Show Last 20 Lines