sanitizer_common: disable format string checking on 32-bits

[dvyukov]

Summary

Check format strings on 64-bits only because we use %zx to print uptr type,
but %zx expects size_t and on 32-bits size_t is defined as 'unsigned int'
while we define uptr as 'unsigned long' which causes lots of -Wformat warnings.

Revert D108042 which disabled all format string checking because of 32-bit warnings.

[dvyukov]

https://reviews.llvm.org/rG45138f788c9b3c4ac5d9ae4479841c411c15190e fixed these warnings already.

[dvyukov]

In D108105#2946171, @dvyukov wrote:

https://reviews.llvm.org/rG45138f788c9b3c4ac5d9ae4479841c411c15190e fixed these warnings already.

Okay, that commit was just reverted... llvm post-commit testing makes it very hard to do any progress...

compiler-rt/lib/sanitizer_common/CMakeLists.txt

 
 include_directories(..)
 
 set(SANITIZER_COMMON_DEFINITIONS
   HAVE_RPC_XDR_H=${HAVE_RPC_XDR_H})
 
 set(SANITIZER_CFLAGS ${SANITIZER_COMMON_CFLAGS})
 
-# Too many existing bugs, needs cleanup.
-append_list_if(COMPILER_RT_HAS_WNO_FORMAT -Wno-format SANITIZER_CFLAGS)
-
 append_rtti_flag(OFF SANITIZER_CFLAGS)
 
 append_list_if(SANITIZER_LIMIT_FRAME_SIZE -Wframe-larger-than=570
                SANITIZER_CFLAGS)
 append_list_if(COMPILER_RT_HAS_WGLOBAL_CONSTRUCTORS_FLAG -Wglobal-constructors
                SANITIZER_CFLAGS)
 
 if(APPLE)

compiler-rt/lib/sanitizer_common/sanitizer_internal_defs.h

 # define PREFETCH(x) /* _mm_prefetch(x, _MM_HINT_NTA) */ (void)0
 # define WARN_UNUSED_RESULT
 #else  // _MSC_VER
 # define ALWAYS_INLINE inline __attribute__((always_inline))
 # define ALIAS(x) __attribute__((alias(x)))
 // Please only use the ALIGNED macro before the type.
 // Using ALIGNED after the variable declaration is not portable!
 # define ALIGNED(x) __attribute__((aligned(x)))
-# define FORMAT(f, a)  __attribute__((format(printf, f, a)))
-# define NOINLINE __attribute__((noinline))
-# define NORETURN  __attribute__((noreturn))
-# define THREADLOCAL   __thread
-# define LIKELY(x)     __builtin_expect(!!(x), 1)
-# define UNLIKELY(x)   __builtin_expect(!!(x), 0)
-# if defined(__i386__) || defined(__x86_64__)
+// Check format strings on 64-bits only because we use %zx to print uptr type,
+// but %zx expects size_t and on 32-bits size_t is defined as 'unsigned int'
+// while we define uptr as 'unsigned long' which causes lots of -Wformat
+// warnings. This can be fixed by defining uptr as 'unsigned int' on 32-bits.
+#  if __LP64__
+#    define FORMAT(f, a) __attribute__((format(printf, f, a)))
+#  else
+#    define FORMAT(f, a)
+#  endif
+#  define NOINLINE __attribute__((noinline))
+#  define NORETURN __attribute__((noreturn))
+#  define THREADLOCAL __thread
+#  define LIKELY(x) __builtin_expect(!!(x), 1)
+#  define UNLIKELY(x) __builtin_expect(!!(x), 0)
+#  if defined(__i386__) || defined(__x86_64__)
 // __builtin_prefetch(x) generates prefetchnt0 on x86
-#  define PREFETCH(x) __asm__("prefetchnta (%0)" : : "r" (x))
-# else
-#  define PREFETCH(x) __builtin_prefetch(x)
-# endif
-# define WARN_UNUSED_RESULT __attribute__((warn_unused_result))
+#    define PREFETCH(x) __asm__("prefetchnta (%0)" : : "r"(x))
+#  else
+#    define PREFETCH(x) __builtin_prefetch(x)
+#  endif
+#  define WARN_UNUSED_RESULT __attribute__((warn_unused_result))
 #endif  // _MSC_VER
 
 #if !defined(_MSC_VER) || defined(__clang__)
 # define UNUSED __attribute__((unused))
 # define USED __attribute__((used))
 #else
 # define UNUSED
 # define USED