This is an archive of the discontinued LLVM Phabricator instance.

Differential D108042

[sanitizer_common] disable format errors.
ClosedPublic

Authored by fmayer on Aug 13 2021, 8:24 AM.

Details

Reviewers
dvyukov
eugenis
Commits
rGb0716269baa3: [sanitizer_common] disable format errors.
Summary

This broke https://lab.llvm.org/buildbot/#/builders/37/builds/6061/steps/32/logs/stdio

Diff Detail

Event Timeline

fmayer created this revision.Aug 13 2021, 8:24 AM
Herald added a subscriber: mgorny. · View Herald TranscriptAug 13 2021, 8:24 AM
fmayer requested review of this revision.Aug 13 2021, 8:24 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 13 2021, 8:24 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript
fmayer added reviewers: dvyukov, eugenis.Aug 13 2021, 8:25 AM
dvyukov added inline comments.Aug 13 2021, 9:07 AM
compiler-rt/lib/sanitizer_common/CMakeLists.txt
206

Please disable it only for 32-bits, since these warnings are 32-bits only.
And move this next to -Wno-format-pedantic to have it all in one place.

dvyukov mentioned this in D107977: sanitizer_common: prepare for enabling format string checking.Aug 13 2021, 9:15 AM
Harbormaster completed remote builds in B119456: Diff 366293.Aug 13 2021, 9:22 AM
fmayer updated this revision to Diff 366303.Aug 13 2021, 9:49 AM

whitespace change

dvyukov accepted this revision.Aug 13 2021, 9:49 AM
dvyukov added inline comments.
compiler-rt/lib/sanitizer_common/CMakeLists.txt
206

As per offline discussion, we agreed to submit this as-is today to unbreak things and fix on Monday.

This revision is now accepted and ready to land.Aug 13 2021, 9:49 AM
This revision was landed with ongoing or failed builds.Aug 13 2021, 9:52 AM
Closed by commit rGb0716269baa3: [sanitizer_common] disable format errors. (authored by fmayer). · Explain Why
This revision was automatically updated to reflect the committed changes.
fmayer marked 2 inline comments as done.
fmayer added a commit: rGb0716269baa3: [sanitizer_common] disable format errors..
Harbormaster completed remote builds in B119462: Diff 366303.Aug 13 2021, 10:23 AM
dvyukov added a reverting change: D108105: sanitizer_common: disable format string checking on 32-bits.Aug 16 2021, 12:27 AM
dvyukov added a comment.Aug 16 2021, 12:28 AM

FTR, I've mailed D108105 because other people are complaining re broken builds:
https://reviews.llvm.org/D107980#2945116
disabling the warning for sanitizer_common only is not enough.

Revision Contents

PathSize
compiler-rt/
lib/
sanitizer_common/
4 lines

Diff 366305

compiler-rt/lib/sanitizer_common/CMakeLists.txt

Show First 20 Lines • Show All 195 Lines • ▼ Show 20 Linesset(SANITIZER_IMPL_HEADERS
) )
include_directories(..) include_directories(..)
set(SANITIZER_COMMON_DEFINITIONS set(SANITIZER_COMMON_DEFINITIONS
HAVE_RPC_XDR_H=${HAVE_RPC_XDR_H}) HAVE_RPC_XDR_H=${HAVE_RPC_XDR_H})
set(SANITIZER_CFLAGS ${SANITIZER_COMMON_CFLAGS}) set(SANITIZER_CFLAGS ${SANITIZER_COMMON_CFLAGS})
# Too many existing bugs, needs cleanup.
append_list_if(COMPILER_RT_HAS_WNO_FORMAT -Wno-format SANITIZER_CFLAGS)
dvyukovUnsubmitted
Done
ReplyInline Actions

Please disable it only for 32-bits, since these warnings are 32-bits only.
And move this next to -Wno-format-pedantic to have it all in one place.

dvyukov: Please disable it only for 32-bits, since these warnings are 32-bits only. And move this next…
dvyukovUnsubmitted
Done
ReplyInline Actions

As per offline discussion, we agreed to submit this as-is today to unbreak things and fix on Monday.

dvyukov: As per offline discussion, we agreed to submit this as-is today to unbreak things and fix on…
append_rtti_flag(OFF SANITIZER_CFLAGS) append_rtti_flag(OFF SANITIZER_CFLAGS)
append_list_if(SANITIZER_LIMIT_FRAME_SIZE -Wframe-larger-than=570 append_list_if(SANITIZER_LIMIT_FRAME_SIZE -Wframe-larger-than=570
SANITIZER_CFLAGS) SANITIZER_CFLAGS)
append_list_if(COMPILER_RT_HAS_WGLOBAL_CONSTRUCTORS_FLAG -Wglobal-constructors append_list_if(COMPILER_RT_HAS_WGLOBAL_CONSTRUCTORS_FLAG -Wglobal-constructors
SANITIZER_CFLAGS) SANITIZER_CFLAGS)
if(APPLE) if(APPLE)
▲ Show 20 Lines • Show All 123 Lines • Show Last 20 Lines