[MLIR] Improve debug messages in BuiltinTypes

[GMNGeoffrey]

Summary

It's nice for users to have more information when debugging failures and
these are only triggered in a failure path.

[rriddle]

mlir/lib/IR/BuiltinTypes.cpp

455

The llvm::to_vector here looks suspicious, why is this necessary?

[GMNGeoffrey]

Drop unnecessary to_vector

[GMNGeoffrey]

mlir/lib/IR/BuiltinTypes.cpp

455

It's not, and I don't know why for some reason I thought it was. I must have misdiagnosed some other error.

mlir/lib/IR/BuiltinTypes.cpp

 //===----------------------------------------------------------------------===//
 
 LogicalResult VectorType::verify(function_ref<InFlightDiagnostic()> emitError,
                                  ArrayRef<int64_t> shape, Type elementType) {
   if (shape.empty())
     return emitError() << "vector types must have at least one dimension";
 
   if (!isValidElementType(elementType))
-    return emitError() << "vector elements must be int/index/float type";
+    return emitError()
+           << "vector elements must be int/index/float type but got "
+           << elementType;
 
   if (any_of(shape, [](int64_t i) { return i <= 0; }))
-    return emitError() << "vector types must have positive constant sizes";
+    return emitError()
+           << "vector types must have positive constant sizes but got "
+           << shape;
 
   return success();
 }
 
 VectorType VectorType::scaleElementBitwidth(unsigned scale) {
   if (!scale)
     return VectorType();
   if (auto et = getElementType().dyn_cast<IntegerType>())