This is an archive of the discontinued LLVM Phabricator instance.

[clang/test] Run thinlto-clang-diagnostic-handler-in-be.c on x86
ClosedPublic

Authored by thopre on Aug 6 2021, 1:58 PM.

Details

Summary

Clang test CodeGen/thinlto-clang-diagnostic-handler-in-be.c fails on
some non x86 targets, e.g. hexagon. Since the test already requires x86
to be available as a target this commit forces the target to x86_64.

Diff Detail

Event Timeline

thopre created this revision.Aug 6 2021, 1:58 PM
thopre requested review of this revision.Aug 6 2021, 1:58 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 6 2021, 1:58 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript

Please don't use x86_64 as target or triple since it might default to some weird platform. Can you spell out a valid triple/platform?

thopre updated this revision to Diff 365425.Aug 10 2021, 4:27 AM

Use x86_64-linux-gnu as triplet

steven_wu accepted this revision.Aug 12 2021, 12:37 PM

LGTM. Thanks

This revision is now accepted and ready to land.Aug 12 2021, 12:37 PM
This revision was landed with ongoing or failed builds.Aug 12 2021, 1:38 PM
This revision was automatically updated to reflect the committed changes.