[clangd] Canonicalize inputs provided with `--`

[kadircet]

Summary

We already strip all the inputs provided without --, this patch also
handles the cases with --.

[sammccall]

clang-tools-extra/clangd/CompileCommands.cpp

250

iterate from dashdash->getIndex() + 1 to Cmd.size() instead?

Or just Cmd.resize(dashdash->getIndex() + 2)?

[kadircet]

• Cmd.resize instead of dropping arguments trailing -- one by one.

[kadircet]

clang-tools-extra/clangd/CompileCommands.cpp

250

ah yes, resize looks a lot better. but we deliberately drop -- too. so that we can always append it without checking again.

clang-tools-extra/clangd/CompileCommands.cpp

void CommandMangler::adjust(std::vector<std::string> &Cmd,
   for (auto *Input : ArgList.filtered(driver::options::OPT_arch)) {
     ++ArchOptCount;
     for (auto I = 0U; I <= Input->getNumValues(); ++I)
       IndicesToDrop.push_back(Input->getIndex() + I);
   }
   // If there is a single `-arch` option, keep it.
   if (ArchOptCount < 2)
     IndicesToDrop.clear();
-  // Move the inputs to the end, separated via `--` from flags. This ensures
-  // modifications done in the following steps apply in more cases (like setting
-  // -x, which only affects inputs that come after it).
-  if (!ArgList.hasArgNoClaim(driver::options::OPT__DASH_DASH)) {
-    // Drop all the inputs and only add one for the current file.
-    for (auto *Input : ArgList.filtered(driver::options::OPT_INPUT))
-      IndicesToDrop.push_back(Input->getIndex());
-    Cmd.push_back("--");
-    Cmd.push_back(File.str());
+
+  // Strip all the inputs and `--`. We'll put the input for the requested file
+  // explicitly at the end of the flags. This ensures modifications done in the
+  // following steps apply in more cases (like setting -x, which only affects
+  // inputs that come after it).
+  // Anything after `--` is also treated as input, drop them as well.
+  if (auto *DashDash =
+          ArgList.getLastArgNoClaim(driver::options::OPT__DASH_DASH)) {
+    Cmd.resize(DashDash->getIndex() + 1); // +1 to account for Cmd[0].
   }
   llvm::sort(IndicesToDrop);
   llvm::for_each(llvm::reverse(IndicesToDrop),
                  // +1 to account for the executable name in Cmd[0] that
                  // doesn't exist in ArgList.
                  [&Cmd](unsigned Idx) { Cmd.erase(Cmd.begin() + Idx + 1); });
+  // All the inputs are stripped, append the name for the requested file. Rest
+  // of the modifications should respect `--`.
+  Cmd.push_back("--");
+  Cmd.push_back(File.str());
 
   for (auto &Edit : Config::current().CompileFlags.Edits)
     Edit(Cmd);
 
   // Check whether the flag exists, either as -flag or -flag=*
   auto Has = [&](llvm::StringRef Flag) {
     for (llvm::StringRef Arg : Cmd) {
       if (Arg.consume_front(Flag) && (Arg.empty() || Arg[0] == '='))

clang-tools-extra/clangd/unittests/CompileCommandsTests.cpp

 
 // Make use of all features and assert the exact command we get out.
 // Other tests just verify presence/absence of certain args.
 TEST(CommandMangler, Everything) {
   auto Mangler = CommandMangler::forTests();
   Mangler.ClangPath = testPath("fake/clang");
   Mangler.ResourceDir = testPath("fake/resources");
   Mangler.Sysroot = testPath("fake/sysroot");
-  std::vector<std::string> Cmd = {"clang++", "--", "foo.cc"};
+  std::vector<std::string> Cmd = {"clang++", "--", "foo.cc", "bar.cc"};
   Mangler.adjust(Cmd, "foo.cc");
   EXPECT_THAT(Cmd, ElementsAre(testPath("fake/clang++"),
                                "-resource-dir=" + testPath("fake/resources"),
                                "-isysroot", testPath("fake/sysroot"), "--",
                                "foo.cc"));
 }
 
 TEST(CommandMangler, ResourceDir) {