This is an archive of the discontinued LLVM Phabricator instance.

Differential D107517

[mlir] Update comment in Region.h
ClosedPublic

Authored by springerm on Aug 4 2021, 5:51 PM.

Details

Reviewers
rriddle
Commits
rGac7c7cbfdaf9: [mlir] Update comment in Region.h
Summary

The file in which Region::viewGraph is defined has changed. This should have been updated with D106342.

Diff Detail

Event Timeline

springerm created this revision.Aug 4 2021, 5:51 PM
Herald added subscribers: wrengr, Chia-hungDuan, dcaballe and 17 others. · View Herald TranscriptAug 4 2021, 5:51 PM
springerm requested review of this revision.Aug 4 2021, 5:51 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 4 2021, 5:51 PM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
Harbormaster completed remote builds in B118046: Diff 364304.Aug 4 2021, 6:37 PM
springerm updated this revision to Diff 364313.Aug 4 2021, 6:55 PM

no change

springerm added a child revision: D107520: [mlir] Clean up includes in Transforms/Passes.h.Aug 4 2021, 6:55 PM
This revision was not accepted when it landed; it landed in state Needs Review.Aug 4 2021, 6:58 PM
This revision was landed with ongoing or failed builds.
Closed by commit rGac7c7cbfdaf9: [mlir] Update comment in Region.h (authored by springerm). · Explain Why
This revision was automatically updated to reflect the committed changes.
springerm added a commit: rGac7c7cbfdaf9: [mlir] Update comment in Region.h.
Harbormaster completed remote builds in B118050: Diff 364313.Aug 4 2021, 7:34 PM

Revision Contents

PathSize
mlir/
include/
mlir/
IR/
2 lines

Diff 364315

mlir/include/mlir/IR/Region.h

Show First 20 Lines • Show All 290 Lines • ▼ Show 20 Linespublic:
} }
//===--------------------------------------------------------------------===// //===--------------------------------------------------------------------===//
// CFG view utilities // CFG view utilities
//===--------------------------------------------------------------------===// //===--------------------------------------------------------------------===//
/// Displays the CFG in a window. This is for use from the debugger and /// Displays the CFG in a window. This is for use from the debugger and
/// depends on Graphviz to generate the graph. /// depends on Graphviz to generate the graph.
/// This function is defined in ViewRegionGraph and only works with that /// This function is defined in ViewOpGraph.cpp and only works with that
/// target linked. /// target linked.
void viewGraph(const Twine &regionName); void viewGraph(const Twine &regionName);
void viewGraph(); void viewGraph();
private: private:
BlockListType blocks; BlockListType blocks;
/// This is the object we are part of. /// This is the object we are part of.
▲ Show 20 Lines • Show All 42 Lines • Show Last 20 Lines