This is an archive of the discontinued LLVM Phabricator instance.

Differential D107497

[PowerPC][AIX] Limit attribute aligned to 4096.
ClosedPublic

Authored by sfertile on Aug 4 2021, 12:53 PM.

Details

Reviewers
Jake-Egan
stevewan
aaron.ballman
Commits
rG5181be344adb: [PowerPC][AIX] Limit attribute aligned to 4096.
Summary

Limit the maximum alignment for attribute aligned to 4096 to match the limit of the .align pseudo op in the system assembler.

Diff Detail

Event Timeline

sfertile created this revision.Aug 4 2021, 12:53 PM
Herald added a reviewer: aaron.ballman. · View Herald TranscriptAug 4 2021, 12:53 PM
Herald added subscribers: shchenz, nemanjai. · View Herald Transcript
sfertile requested review of this revision.Aug 4 2021, 12:53 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 4 2021, 12:53 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
Harbormaster completed remote builds in B117988: Diff 364225.Aug 4 2021, 1:57 PM
sfertile updated this revision to Diff 364264.Aug 4 2021, 3:12 PM

Fix formatting.

Harbormaster completed remote builds in B118017: Diff 364264.Aug 4 2021, 4:07 PM
aaron.ballman accepted this revision.Aug 5 2021, 4:27 AM

LGTM!

This revision is now accepted and ready to land.Aug 5 2021, 4:27 AM
Closed by commit rG5181be344adb: [PowerPC][AIX] Limit attribute aligned to 4096. (authored by sfertile). · Explain WhyAug 5 2021, 6:51 AM
This revision was automatically updated to reflect the committed changes.
sfertile added a commit: rG5181be344adb: [PowerPC][AIX] Limit attribute aligned to 4096..
sfertile added a reverting change: rGdddd524bb884: Revert "[PowerPC][AIX] Limit attribute aligned to 4096.".Aug 6 2021, 10:56 AM

Revision Contents

PathSize
clang/
lib/
Sema/
3 lines
test/
Sema/
4 lines

Diff 364225

clang/lib/Sema/SemaDeclAttr.cpp

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 4,048 Lines • ▼ Show 20 Lines if (!llvm::isPowerOf2_64(AlignVal)) {
<< E->getSourceRange(); << E->getSourceRange();
return; return;
} }
} }
unsigned MaximumAlignment = Sema::MaximumAlignment; unsigned MaximumAlignment = Sema::MaximumAlignment;
if (Context.getTargetInfo().getTriple().isOSBinFormatCOFF()) if (Context.getTargetInfo().getTriple().isOSBinFormatCOFF())
MaximumAlignment = std::min(MaximumAlignment, 8192u); MaximumAlignment = std::min(MaximumAlignment, 8192u);
else if(Context.getTargetInfo().getTriple().isOSAIX())
Lint: Pre-merge checks
Inline Actions

clang-format: please reformat the code

-  else if(Context.getTargetInfo().getTriple().isOSAIX())
+  else if (Context.getTargetInfo().getTriple().isOSAIX())
Lint: Pre-merge checks: clang-format: please reformat the code ``` - else if(Context.getTargetInfo().getTriple().
MaximumAlignment = std::min(MaximumAlignment, 4096u);
if (AlignVal > MaximumAlignment) { if (AlignVal > MaximumAlignment) {
Diag(AttrLoc, diag::err_attribute_aligned_too_great) Diag(AttrLoc, diag::err_attribute_aligned_too_great)
<< MaximumAlignment << E->getSourceRange(); << MaximumAlignment << E->getSourceRange();
return; return;
} }
if (Context.getTargetInfo().isTLSSupported()) { if (Context.getTargetInfo().isTLSSupported()) {
unsigned MaxTLSAlign = unsigned MaxTLSAlign =
▲ Show 20 Lines • Show All 4,762 Lines • Show Last 20 Lines

clang/test/Sema/aix-attr-aligned-limit.c

  • This file was added.
// RUN: %clang_cc1 -triple powerpc-unknown-aix -fsyntax-only -verify %s
// RUN: %clang_cc1 -triple powerpc64-unknown-aix -fsyntax-only -verify %s
//
int a __attribute__((aligned(8192))); // expected-error {{requested alignment must be 4096 bytes or smaller}}