This is an archive of the discontinued LLVM Phabricator instance.

Differential D107484

[mlir][sparse] Remove comment w/ code in it
ClosedPublic

Authored by gussmith23 on Aug 4 2021, 10:40 AM.

Details

Reviewers
aartbik
Commits
rG0bd2d4c4b163: [mlir][sparse] Remove comment w/ code in it

Diff Detail

Event Timeline

gussmith23 created this revision.Aug 4 2021, 10:40 AM
Herald added subscribers: wrengr, Chia-hungDuan, dcaballe and 18 others. · View Herald TranscriptAug 4 2021, 10:40 AM
gussmith23 requested review of this revision.Aug 4 2021, 10:40 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 4 2021, 10:40 AM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
gussmith23 added a reviewer: aartbik.Aug 4 2021, 10:40 AM
aartbik accepted this revision.Aug 4 2021, 10:41 AM

Thanks Gus.

This revision is now accepted and ready to land.Aug 4 2021, 10:41 AM
aartbik added inline comments.Aug 4 2021, 10:57 AM
mlir/test/Integration/data/mttkrp_b.tns
8

oh, now that you are here, replace matrix -> tensor

gussmith23 updated this revision to Diff 364189.Aug 4 2021, 10:59 AM

matrix -> tensor

gussmith23 marked an inline comment as done.Aug 4 2021, 10:59 AM
Harbormaster completed remote builds in B117963: Diff 364189.Aug 4 2021, 11:23 AM
aartbik accepted this revision.Aug 4 2021, 1:01 PM

Ship it!

Closed by commit rG0bd2d4c4b163: [mlir][sparse] Remove comment w/ code in it (authored by gussmith23). · Explain WhyAug 4 2021, 2:41 PM
This revision was automatically updated to reflect the committed changes.
gussmith23 added a commit: rG0bd2d4c4b163: [mlir][sparse] Remove comment w/ code in it.

Revision Contents

PathSize
mlir/
test/
Integration/
data/
38 lines

Diff 364249

mlir/test/Integration/data/mttkrp_b.tns

# This is a rank 3 test sparse tensor in FROSTT file format, # This is a rank 3 test sparse tensor in FROSTT file format,
# extended with two meta data lines: # extended with two meta data lines:
# rank nnz # rank nnz
# dims (one per rank) # dims (one per rank)
# #
# see http://frostt.io/tensors/file-formats.html # see http://frostt.io/tensors/file-formats.html
# #
# This matrix represents the "B" input to the MTTKRP kernel: # This tensor represents the "B" input to the MTTKRP kernel:
aartbikUnsubmitted
Done
ReplyInline Actions

oh, now that you are here, replace matrix -> tensor

aartbik: oh, now that you are here, replace matrix -> tensor
# http://tensor-compiler.org/docs/data_analytics/index.html # http://tensor-compiler.org/docs/data_analytics/index.html
#
# It can be generated with the following script, adapted from the above link:
#
#> import pytaco as pt
#> import numpy as np
#> from pytaco import compressed, dense
#> import random
#>
#> # Define formats for storing the sparse tensor and dense matrices.
#> csf = pt.format([compressed, compressed, compressed])
#> rm = pt.format([dense, dense])
#
#> B=pt.tensor((2,3,4),csf)
#> density = 0.25
#> for i in range(2):
#> for j in range(3):
#> for k in range(4):
#> if random.random() > density:
#> B.insert((i,j,k), random.randint(0,100))
#>
#> C = pt.from_array(np.arange(B.shape[1]*5).reshape(B.shape[1],5))
#> D = pt.from_array(np.arange(B.shape[2]*5).reshape(B.shape[2],5))
#>
#> # Declare the result to be a dense matrix.
#> A = pt.tensor([B.shape[0], 5], rm)
#>
#> # Declare index vars.
#> i, j, k, l = pt.get_index_vars(4)
#>
#> # Define the MTTKRP computation.
#> A[i, j] = B[i, k, l] * D[l, j] * C[k, j]
#>
#> # Perform the MTTKRP computation and write the result to file.
#> pt.write("A.tns", A)
#> pt.write("B.tns", B)
#
3 17 3 17
2 3 4 2 3 4
1 1 3 3 1 1 3 3
1 1 4 63 1 1 4 63
1 2 2 11 1 2 2 11
1 2 3 100 1 2 3 100
1 3 1 66 1 3 1 66
1 3 2 61 1 3 2 61
Show All 11 Lines