This is an archive of the discontinued LLVM Phabricator instance.

[SelectionDAG] Correctly determine the VECREDUCE_SEQ_FMUL action
ClosedPublic

Authored by frasercrmck on Aug 4 2021, 9:51 AM.

Details

Summary

The LegalizeAction for this node should follow the logic for
VECREDUCE_SEQ_FADD and be determined using the vector operand's type.

here isn't an in-tree target that makes use of this, but I think it's safe to
say this is how it should behave, should a target want to customize the action
for this node.

Diff Detail

Event Timeline

frasercrmck created this revision.Aug 4 2021, 9:51 AM
frasercrmck requested review of this revision.Aug 4 2021, 9:51 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 4 2021, 9:51 AM
dmgreen accepted this revision.Aug 5 2021, 12:06 AM
dmgreen added a subscriber: dmgreen.

Looks correct to me, and I don't see anywhere else where VECREDUCE_SEQ_FMUL is missing compared to VECREDUCE_SEQ_FADD

This revision is now accepted and ready to land.Aug 5 2021, 12:06 AM
  • rebase to give the buildbots a go