This is an archive of the discontinued LLVM Phabricator instance.

[PatternRewriter] Disable copy/assign operators.
ClosedPublic

Authored by lattner on Jul 31 2021, 3:11 PM.

Details

Summary

We had a bad bug over in CIRCT
caused by accidentally passing around PatternRewriter
by value. There is no reason to support copy/assignment
of the pattern rewriter, so disable it.

Diff Detail

Event Timeline

lattner created this revision.Jul 31 2021, 3:11 PM
lattner requested review of this revision.Jul 31 2021, 3:11 PM
This revision was not accepted when it landed; it landed in state Needs Review.Aug 2 2021, 10:26 AM
This revision was automatically updated to reflect the committed changes.

I committed this as "obvious", lemme know if you have any concerns and I'll revert.

LG, thanks!