This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU] Autogenerate checks in kernel-args.ll
ClosedPublic

Authored by foad on Jul 29 2021, 2:56 AM.

Diff Detail

Event Timeline

foad created this revision.Jul 29 2021, 2:56 AM
foad requested review of this revision.Jul 29 2021, 2:56 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 29 2021, 2:56 AM
foad added inline comments.Jul 29 2021, 3:00 AM
llvm/test/CodeGen/AMDGPU/kernel-args.ll
1

I removed -allow-deprecated-dag-overlap and -enable-var-scope because I didn't know what they were for.

2

I removed -mattr=-flat-for-global because I assumed it was only added in the first place to avoid churn in the tests when some compiler default was changed.

3

I removed --amdhsa-code-object-version=2 because it seemed to bloat the checks with a load of directives starting with .amd_kernel_code_t.

lebedev.ri accepted this revision.Jul 30 2021, 7:40 AM
lebedev.ri added a subscriber: lebedev.ri.

Thanks. Non-AMDGPU-specific part this looks fine to me.
Not sure if @arsenm/etc want to stamp this, or if this needs review at all.
For context, this makes the diff in D106447 much more non-unreadable/misleading.

llvm/test/CodeGen/AMDGPU/kernel-args.ll
1

These don't really matter for autogenerated check lines

This revision is now accepted and ready to land.Jul 30 2021, 7:40 AM
arsenm accepted this revision.Jul 30 2021, 11:14 AM
This revision was automatically updated to reflect the committed changes.