Page MenuHomePhabricator

[llvm-objdump][NFC] Add quiet disassembly
AcceptedPublic

Authored by necipfazil on Jul 28 2021, 9:49 PM.

Details

Summary

Add a boolean to control whether object disassembly (disassembleObject())
prints. It is always set to false, which makes this an NFC.

It will be set for the upcoming --call-graph-info option, which will utilize
disassembleObject() to collect function and call site addresses.

Patch 1/6: Extract call graph information from binary

Original RFC: https://lists.llvm.org/pipermail/llvm-dev/2021-June/151044.html
Updated RFC: https://lists.llvm.org/pipermail/llvm-dev/2021-July/151739.html

Diff Detail

Event Timeline

necipfazil created this revision.Jul 28 2021, 9:49 PM
necipfazil requested review of this revision.Jul 28 2021, 9:49 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 28 2021, 9:49 PM
morehouse accepted this revision.Jul 29 2021, 3:06 PM
morehouse added inline comments.
llvm/tools/llvm-objdump/llvm-objdump.cpp
222
This revision is now accepted and ready to land.Jul 29 2021, 3:06 PM
necipfazil marked an inline comment as done.

Fix nit