This is an archive of the discontinued LLVM Phabricator instance.

[Bazel] Derive targets from file presence as in CMake build
ClosedPublic

Authored by GMNGeoffrey on Jul 28 2021, 6:40 PM.

Details

Summary

This makes the logic used to determine if targets have the given
features the same as is used in CMake. Incidentally, it enables these
features for the targets added in https://reviews.llvm.org/D106921
which were missing because this was previously a hardcoded list.

Diff Detail

Event Timeline

GMNGeoffrey created this revision.Jul 28 2021, 6:40 PM
GMNGeoffrey requested review of this revision.Jul 28 2021, 6:40 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 28 2021, 6:40 PM

Switch to an if instead of a double comprehension. Allows use for AsmPrinter too

GMNGeoffrey edited the summary of this revision. (Show Details)Jul 28 2021, 7:49 PM
GMNGeoffrey added a subscriber: izuk.
GMNGeoffrey edited the summary of this revision. (Show Details)Jul 29 2021, 3:50 PM
chandlerc accepted this revision.Jul 29 2021, 6:06 PM

LGTM

utils/bazel/llvm-project-overlay/llvm/BUILD.bazel
8

Should we detect the targets themselves the same way?

This revision is now accepted and ready to land.Jul 29 2021, 6:06 PM