Page MenuHomePhabricator

[NewPM] Add CrossDSOCFI pass irrespective of LTO optimization level
ClosedPublic

Authored by pirama on Jul 23 2021, 12:19 PM.

Details

Summary

This pass is not an optimization and is needed for CFI functionality
(cross-dso verification).

Diff Detail

Event Timeline

pirama created this revision.Jul 23 2021, 12:19 PM
pirama requested review of this revision.Jul 23 2021, 12:19 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 23 2021, 12:19 PM
pirama updated this revision to Diff 361300.Jul 23 2021, 12:22 PM

s/CHECK-LTO/CHECK-LTO-NEXT in new-pm-O0-defaults.ll

aeubanks accepted this revision.Jul 23 2021, 12:22 PM

thanks!

llvm/lib/Passes/PassBuilder.cpp
1651–1652

this comment seems unnecessary, many passes are required

This revision is now accepted and ready to land.Jul 23 2021, 12:22 PM
pirama updated this revision to Diff 361301.Jul 23 2021, 12:24 PM

Remove note in comment.

This revision was landed with ongoing or failed builds.Jul 23 2021, 2:13 PM
This revision was automatically updated to reflect the committed changes.