Differential D106436
sanitizers: increase .clang-format columns to 100 Authored by dvyukov on Jul 21 2021, 6:45 AM.
Details The current (default) line length is 80 columns. This change intentionally does not re-format code.
Diff Detail
Event TimelineComment Actions Good question. It looks good to me. E.g. lines 129, 186, 195 are close to 100 columns and look just fine (at least on my display) and look easier to review in future as a single line. Comment Actions This change is inconsistent with the LLVM style: https://llvm.org/docs/CodingStandards.html#id17 - I think it's important that we don't create more divergence in style between different directories/subprojects. Not everyone's going to use clang-format, for instance, making for some weird formatting choices. (admittedly the transition, as more lines are formatted for 100 lines will get a bit weird/haphazard/inconsistent too - but I'm not too fussed about that) I'd pretty strongly prefer this be reverted and, if desired, discussed across the project as a whole, perhaps. Comment Actions (also, perhaps these .clang-format files could be deduplicated by moving them to the compiler-rt/lib directory? (I guess there's enough other directories in there that are sticking with 80 cols that that would need more opt-outs than these opt-ins - though perhaps that goes to my original point that that makes even more divergence/variation within the project when it's customized at this fairly narrow granularity that 9 separate directories are opting in to this choice)) Comment Actions +1 |