This patch makes it possible to query callbase reachability
(Can a callbase reach a function Fn transitively).
The patch moves the reachability query handling logic to a member class,
this class will have more users within the AA once we add other function
reachability queries.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
- Use early increment iterator range rather than hacky code.
- Fix the infinite loop issue.
- Negative test case.
llvm/lib/Transforms/IPO/AttributorAttributes.cpp | ||
---|---|---|
9546 | I don't get this. In line 9331 we iterate over unreachable and ask isReachable but we always would return false because of this, no? | |
9597 | ||
9622 | You can use recordDependence here to make it clear what is happening and avoid some unnecessary code. | |
9671 | Documentation for both. |
I don't get this. In line 9331 we iterate over unreachable and ask isReachable but we always would return false because of this, no?