Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

Differential D106390

[OpenMP] Renaming RT functions `GetNumberOfBlocksInKernel` and `GetNumberOfThreadsInBlock`
ClosedPublic
Actions

Authored by josemonsalve2 on Jul 20 2021, 12:51 PM.

Details

Reviewers
jdoerfert
tianshilei1992
JonChesterfield
ggeorgakoudis
jhuber6
Commits
rG68d6278a6e98: [OpenMP] Renaming RT functions `GetNumberOfBlocksInKernel` and…
Summary

These functions should follow the camel case convention. These are really easy to change
and are needed for D106033.

Diff Detail

Event Timeline

josemonsalve2 created this revision.Jul 20 2021, 12:51 PM
Herald added subscribers: guansong, yaxunl, jvesely. · View Herald TranscriptJul 20 2021, 12:51 PM
josemonsalve2 requested review of this revision.Jul 20 2021, 12:51 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 20 2021, 12:51 PM
Herald added subscribers: openmp-commits, sstefan1. · View Herald Transcript
josemonsalve2 added a child revision: D106033: [OpenMP] Folding threadLimit and numThreads when single value in kernels.Jul 20 2021, 12:52 PM
Harbormaster completed remote builds in B115171: Diff 360243.Jul 20 2021, 2:06 PM
JonChesterfield accepted this revision.Jul 21 2021, 1:32 AM

The __kmpc_ convention is consistent with the rest of the interface

This revision is now accepted and ready to land.Jul 21 2021, 1:32 AM
josemonsalve2 updated this revision to Diff 360957.Jul 22 2021, 1:44 PM

Merging upstream main

This revision was landed with ongoing or failed builds.Jul 22 2021, 3:17 PM
Closed by commit rG68d6278a6e98: [OpenMP] Renaming RT functions `GetNumberOfBlocksInKernel` and… (authored by Jose M Monsalve Diaz <jmonsalvediaz@anl.gov>, committed by tianshilei1992). · Explain Why
This revision was automatically updated to reflect the committed changes.
tianshilei1992 added a commit: rG68d6278a6e98: [OpenMP] Renaming RT functions `GetNumberOfBlocksInKernel` and….
Harbormaster completed remote builds in B115679: Diff 360957.Jul 22 2021, 3:55 PM
tianshilei1992 removed a child revision: D106033: [OpenMP] Folding threadLimit and numThreads when single value in kernels.Jul 27 2021, 5:11 PM
tianshilei1992 added a child revision: D106033: [OpenMP] Folding threadLimit and numThreads when single value in kernels.Jul 27 2021, 5:20 PM
jdoerfert mentioned this in D133949: Make sure the right parameter extension attributes are added in various instrumentation passes..Dec 19 2022, 4:01 PM

Revision Contents
Changeset List

PathSize
openmp/
libomptarget/
deviceRTLs/
amdgcn/
src/
6 lines
common/
src/
4 lines
4 lines
2 lines
8 lines
nvptx/
src/
6 lines
4 lines

Diff 360996

View Options

openmp/libomptarget/deviceRTLs/amdgcn/src/target_impl.hip

Loading...
View Options

openmp/libomptarget/deviceRTLs/common/src/libcall.cu

Loading...
View Options

openmp/libomptarget/deviceRTLs/common/src/omptarget.cu

Loading...
View Options

openmp/libomptarget/deviceRTLs/common/src/reduction.cu

Loading...
View Options

openmp/libomptarget/deviceRTLs/common/src/support.cu

Loading...
View Options

openmp/libomptarget/deviceRTLs/nvptx/src/target_impl.cu

Loading...
View Options

openmp/libomptarget/deviceRTLs/target_interface.h

Loading...