[NFC] Fix some comments and only look at terminators when looking for ReturnLike ops

[jurahul]

Summary

Minor cleanup.

[herhut]

Thanks.

mlir/include/mlir/Analysis/BufferViewFlowAnalysis.h

public:
   }
 
   /// Returns the begin iterator to iterate over all dependencies.
   ValueMapT::const_iterator begin() const { return dependencies.begin(); }
 
   /// Returns the end iterator that can be used in combination with find.
   ValueMapT::const_iterator end() const { return dependencies.end(); }
 
-  /// Find all immediate and indirect views upong this value. This will find all
+  /// Find all immediate and indirect views upon this value. This will find all
   /// dependencies on this value that can potentially be later in the execution
   /// of the program, but will not return values that this alias might have been
-  /// created from (such as if `value is created by a subview, this will not
+  /// created from (such as if the value is created by a subview, this will not
   /// return the parent view if there is no cyclic behavior). Note that the
   /// resulting set will also contain the value provided as it is an alias of
   /// itself.
   ///
   /// A = *
   /// B = subview(A)
   /// C = B
   ///

mlir/lib/Analysis/BufferViewFlowAnalysis.cpp

for (Region &region : regionInterface->getRegions()) {
       // current region.
       SmallVector<RegionSuccessor, 2> successorRegions;
       regionInterface.getSuccessorRegions(region.getRegionNumber(),
                                           successorRegions);
       for (RegionSuccessor &successorRegion : successorRegions) {
         // Iterate over all immediate terminator operations and wire the
         // successor inputs with the operands of each terminator.
         for (Block &block : region) {
-          for (Operation &operation : block) {
-            if (operation.hasTrait<OpTrait::ReturnLike>())
-              registerDependencies(operation.getOperands(),
-                                   successorRegion.getSuccessorInputs());
+          Operation &terminator = *block.getTerminator();
+          if (terminator.hasTrait<OpTrait::ReturnLike>()) {
+            registerDependencies(terminator.getOperands(),
           }
         }
       }
     }
   });
 }