Fixed a minor writing error. The text was hard to understand.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Unit Tests
Event Timeline
llvm/docs/tutorial/BuildingAJIT2.rst | ||
---|---|---|
232 | Nit: there is a trailing space here. | |
233 | "Each layer can complete its own work ..." ? | |
240 | I think these two added new lines aren't needed, are they? | |
244 | Nit: You have some initial empty space at the beginning of these lines apparently | |
250 | Probably should reflow here to preserve the 80cols |
I fixed it as instructed by the reviewer.
Removed trailing spaces and no needed empty spaces.
Preserve 80cols at all lines.
Thank you.
llvm/docs/tutorial/BuildingAJIT2.rst | ||
---|---|---|
261 | I'm not sure this sentence is actually more clear. You're trying to go from a passive form to an active form, but it goes with introducing someone as the subject, which does not seem like usual to me when describing some piece of code calling another piece of code. |
I'm not sure this sentence is actually more clear. You're trying to go from a passive form to an active form, but it goes with introducing someone as the subject, which does not seem like usual to me when describing some piece of code calling another piece of code.
Are you following some guidelines on technical documentation here?
No.
I think it's more clear...
I'm not so sure about that. I'll think about it some more.
Probably worth including the JIT owner & author (@lhames) in reviews/changes to the JIT documentation.
Very belatedly: These changes look good to me. :)
llvm/docs/tutorial/BuildingAJIT2.rst | ||
---|---|---|
261 | Agreed -- introducing "someone" here feels slightly awkward. I don't have strong feelings though, and the rest of the changes look good. |
llvm/docs/tutorial/BuildingAJIT2.rst | ||
---|---|---|
261 | Yes, someone feels awkward. |
Removed "someone" expression.
I replaced the sentence pointed out by three reviewers with the current one.
llvm/docs/tutorial/BuildingAJIT2.rst | ||
---|---|---|
261 | I'm not sure remove "the" from "to the layer's emit method" is correct here? |
Nit: there is a trailing space here.