This is an archive of the discontinued LLVM Phabricator instance.

Differential D106227

Fix duplicate checks in clangd comments
ClosedPublic

Authored by 1ntEgr8 on Jul 17 2021, 2:56 PM.

Details

Reviewers
nhaehnle
kadircet
Commits
rG195786d7c260: Fix duplicate checks in clangd comments
Summary

This patch removes a duplicate checks in the top-level comments in clang-tools-extra/clangd/ParsedAST.h

Diff Detail

Event Timeline

1ntEgr8 created this revision.Jul 17 2021, 2:56 PM
Herald added subscribers: usaxena95, kadircet, arphaman. · View Herald TranscriptJul 17 2021, 2:56 PM
1ntEgr8 requested review of this revision.Jul 17 2021, 2:56 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 17 2021, 2:56 PM
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. · View Herald Transcript
1ntEgr8 retitled this revision from Fix duplicate checks in clangd documentation to Fix duplicate checks in clangd comments.Jul 17 2021, 3:01 PM
1ntEgr8 edited the summary of this revision. (Show Details)
1ntEgr8 added a reviewer: nhaehnle.
Harbormaster completed remote builds in B114698: Diff 359582.Jul 17 2021, 3:42 PM
kadircet accepted this revision.EditedJul 19 2021, 12:43 AM

thanks! please let me know if I should land this for you (and provide an email address for attributing the commit to)

This revision is now accepted and ready to land.Jul 19 2021, 12:43 AM
1ntEgr8 added a comment.Jul 19 2021, 5:49 AM
In D106227#2886547, @kadircet wrote:

thanks! please let me know if I should land this for you (and provide an email address for attributing the commit to)

sure thing! you can attribute it to eltonp3103@gmail.com

Closed by commit rG195786d7c260: Fix duplicate checks in clangd comments (authored by 1ntEgr8, committed by kadircet). · Explain WhyJul 19 2021, 6:15 AM
This revision was automatically updated to reflect the committed changes.
kadircet added a commit: rG195786d7c260: Fix duplicate checks in clangd comments.

Revision Contents

PathSize
clang-tools-extra/
clangd/
2 lines

Diff 359582

clang-tools-extra/clangd/ParsedAST.h

//===--- ParsedAST.h - Building translation units ----------------*- C++-*-===// //===--- ParsedAST.h - Building translation units ----------------*- C++-*-===//
Lint: Lint
Inline Actions

clang-format not found in user’s local PATH; not linting file.

Lint: Lint: clang-format not found in user’s local PATH; not linting file.
// //
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information. // See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// //
// This file exposes building a file as if it were open in clangd, and defines // This file exposes building a file as if it were open in clangd, and defines
// the ParsedAST structure that holds the results. // the ParsedAST structure that holds the results.
// //
// This is similar to a clang -fsyntax-only run that produces a clang AST, but // This is similar to a clang -fsyntax-only run that produces a clang AST, but
// we have several customizations: // we have several customizations:
// - preamble handling // - preamble handling
// - capturing diagnostics for later access // - capturing diagnostics for later access
// - running clang-tidy checks checks // - running clang-tidy checks
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
#ifndef LLVM_CLANG_TOOLS_EXTRA_CLANGD_PARSEDAST_H #ifndef LLVM_CLANG_TOOLS_EXTRA_CLANGD_PARSEDAST_H
#define LLVM_CLANG_TOOLS_EXTRA_CLANGD_PARSEDAST_H #define LLVM_CLANG_TOOLS_EXTRA_CLANGD_PARSEDAST_H
#include "CollectMacros.h" #include "CollectMacros.h"
#include "Compiler.h" #include "Compiler.h"
▲ Show 20 Lines • Show All 136 Lines • Show Last 20 Lines