This is an archive of the discontinued LLVM Phabricator instance.

[analyzer] Move test case to existing test file and remove duplicated test file.
ClosedPublic

Authored by ASDenysPetrov on Jul 16 2021, 7:20 AM.

Download Raw Diff

Details

Reviewers

NoQ
vsavchenko

Commits

rG497b1b95e606: [analyzer] Move test case to existing test file and remove duplicated test file.

Summary

Move the test case to existing test file. Remove test file as duplicated. The file was mistakenly added due to concerns of a hidden bug (see D104381). After it turned out, that the bug was already fixed with another revision (D85817) and corresponding test was added as well, we can remove this file.

Diff Detail

Unit TestsFailed

	Time	Test
	2,710 ms	x64 debian > libarcher.barrier::barrier.c
	2,620 ms	x64 debian > libarcher.critical::critical.c
	2,490 ms	x64 debian > libarcher.critical::lock-nested.c
	2,830 ms	x64 debian > libarcher.parallel::parallel-simple2.c
	2,730 ms	x64 debian > libarcher.races::critical-unrelated.c
		View Full Test Results (20 Failed)

Event Timeline

ASDenysPetrov created this revision.Jul 16 2021, 7:20 AM

Herald added subscribers: manas, steakhal, dkrupp and 7 others. · View Herald TranscriptJul 16 2021, 7:20 AM

ASDenysPetrov requested review of this revision.Jul 16 2021, 7:20 AM

Herald added a subscriber: cfe-commits. · View Herald TranscriptJul 16 2021, 7:20 AM

ASDenysPetrov added a reviewer: vsavchenko.Jul 16 2021, 7:21 AM

Harbormaster completed remote builds in B114492: Diff 359312.Jul 16 2021, 9:39 AM

I have no opinion here. There's nothing wrong with having more tests and they don't look like exact duplicates of each other(?)

This revision is now accepted and ready to land.Jul 16 2021, 7:55 PM

In D106152#2885091, @NoQ wrote:

I have no opinion here. There's nothing wrong with having more tests and they don't look like exact duplicates of each other(?)

OK, let's just make a compromise and move this test into existing one instead of removing. WDYT?

Moved the test case to existing file.

Harbormaster completed remote builds in B114801: Diff 359710.Jul 19 2021, 3:14 AM

@NoQ just a ping

I think the patch is pretty safe, then I decided to load it.

Closed by commit rG497b1b95e606: [analyzer] Move test case to existing test file and remove duplicated test file. (authored by ASDenysPetrov). · Explain WhyAug 10 2021, 9:12 AM

This revision was automatically updated to reflect the committed changes.

ASDenysPetrov added a commit: rG497b1b95e606: [analyzer] Move test case to existing test file and remove duplicated test file..

Revision Contents

Path

Size

clang/

test/

Analysis/

diagnostics/

PR46264.cpp

Diff 359312

clang/test/Analysis/diagnostics/PR46264.cpp

This file was deleted.

	// RUN: %clang_analyze_cc1 -analyzer-checker=core -analyzer-output=text -verify %s

	// PR46264
	// This case shall not crash with an assertion failure about void* dereferening.
	// The crash has been last seen on commit
	// `3ed8ebc2f6b8172bed48cc5986d3b7af4cfca1bc` from 24.05.2020.
	namespace ns1 {
	namespace a {
	class b {
	public:
	typedef int b::*c;
	operator c() { return d ? &b::d : 0; }
	// expected-note@-1{{'?' condition is true}}
	// expected-note@-2{{Assuming field 'd' is not equal to 0}}
	// expected-note@-3{{Returning value, which participates in a condition later}}
	int d;
	};
	} // namespace a
	using a::b;
	class e {
	void f();
	void g();
	b h;
	};
	void e::f() {
	e *i;
	// expected-note@-1{{'i' declared without an initial value}}
	if (h)
	// expected-note@-1{{Taking true branch}}
	// expected-note@-2{{'b::operator int ns1::a::b::*'}}
	// expected-note@-3{{Returning from 'b::operator int ns1::a::b::*'}}
	i->g();
	// expected-note@-1{{Called C++ object pointer is uninitialized}}
	// expected-warning@-2{{Called C++ object pointer is uninitialized}}
	}
	} // namespace ns1